test: refactor test-http-abort-before-end

This test was added over six years ago, and the behavior seems to have changed since then. When the test was originally written, common.mustCall() did not exist. The only assertion in this test was not actually executing. Instead of an 'error' event being emitted as expected, an 'abort' event was emitted. PR-URL: #18508 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: cjihrig

test/parallel/test-http-abort-before-end.js

@@ -22,25 +22,22 @@
 'use strict';
 constcommon=require('../common');
 consthttp=require('http');
-constassert=require('assert');
 
 constserver=http.createServer(common.mustNotCall());
 
-server.listen(0,function(){
+server.listen(0,common.mustCall(()=>{
 constreq=http.request({
 method: 'GET',
 host: '127.0.0.1',
-port: this.address().port
+port: server.address().port
 });
 
-req.on('error',function(ex){
-// https://github.com/joyent/node/issues/1399#issuecomment-2597359
-// abort() should emit an Error, not the net.Socket object
-assert(exinstanceofError);
-});
+req.on('abort',common.mustCall(()=>{
+server.close();
+}));
+
+req.on('error',common.mustNotCall());
 
 req.abort();
 req.end();
-
-server.close();
-});
+}));