test_runner: refactor and simplify internals

This commit refactors some of the internals of the test runner. PR-URL: #53921 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: cjihrig

lib/internal/test_runner/harness.js

@@ -208,7 +208,7 @@ function setup(root){
 };
 },
 counters: null,
-shouldColorizeTestFiles: false,
+shouldColorizeTestFiles: shouldColorizeTestFiles(globalOptions.destinations),
 teardown: exitHandler,
 snapshotManager: null,
 };
@@ -218,48 +218,46 @@ function setup(root){
 }
 
 letglobalRoot;
-letreportersSetup;
-functiongetGlobalRoot(){
+letasyncBootstrap;
+functionlazyBootstrapRoot(){
 if(!globalRoot){
 globalRoot=createTestTree({__proto__: null,entryFile: process.argv?.[1]});
 globalRoot.reporter.on('test:fail',(data)=>{
 if(data.todo===undefined||data.todo===false){
 process.exitCode=kGenericUserError;
 }
 });
-reportersSetup=setupTestReporters(globalRoot.reporter);
-globalRoot.harness.shouldColorizeTestFiles||=shouldColorizeTestFiles(globalRoot);
+asyncBootstrap=setupTestReporters(globalRoot.reporter);
 }
 returnglobalRoot;
 }
 
 asyncfunctionstartSubtest(subtest){
-if(reportersSetup){
+if(asyncBootstrap){
 // Only incur the overhead of awaiting the Promise once.
-awaitreportersSetup;
-reportersSetup=undefined;
-}
-
-constroot=getGlobalRoot();
-if(!root.harness.bootstrapComplete){
-root.harness.bootstrapComplete=true;
-queueMicrotask(()=>{
-root.harness.allowTestsToRun=true;
-root.processPendingSubtests();
-});
+awaitasyncBootstrap;
+asyncBootstrap=undefined;
+if(!subtest.root.harness.bootstrapComplete){
+subtest.root.harness.bootstrapComplete=true;
+queueMicrotask(()=>{
+subtest.root.harness.allowTestsToRun=true;
+subtest.root.processPendingSubtests();
+});
+}
 }
 
 awaitsubtest.start();
 }
 
 functionrunInParentContext(Factory){
 functionrun(name,options,fn,overrides){
-constparent=testResources.get(executionAsyncId())||getGlobalRoot();
+constparent=testResources.get(executionAsyncId())||lazyBootstrapRoot();
 constsubtest=parent.createSubtest(Factory,name,options,fn,overrides);
-if(!(parentinstanceofSuite)){
-returnstartSubtest(subtest);
+if(parentinstanceofSuite){
+returnPromiseResolve();
 }
-returnPromiseResolve();
+
+returnstartSubtest(subtest);
 }
 
 consttest=(name,options,fn)=>{
@@ -286,7 +284,7 @@ function runInParentContext(Factory){
 
 functionhook(hook){
 return(fn,options)=>{
-constparent=testResources.get(executionAsyncId())||getGlobalRoot();
+constparent=testResources.get(executionAsyncId())||lazyBootstrapRoot();
 parent.createHook(hook,fn,{
 __proto__: null,
  ...options,

lib/internal/test_runner/runner.js

@@ -70,7 +70,6 @@ const{
  convertStringToRegExp,
  countCompletedTest,
  kDefaultPattern,
- shouldColorizeTestFiles,
 }=require('internal/test_runner/utils');
 const{ Glob }=require('internal/fs/glob');
 const{ once }=require('events');
@@ -552,7 +551,6 @@ function run(options = kEmptyObject){
 }
 
 constroot=createTestTree({__proto__: null, concurrency, timeout, signal });
-root.harness.shouldColorizeTestFiles||=shouldColorizeTestFiles(root);
 
 if(process.env.NODE_TEST_CONTEXT!==undefined){
 process.emitWarning('node:test run() is being called recursively within a test file. skipping running files.');

lib/internal/test_runner/test.js

@@ -75,7 +75,6 @@ const kHookFailure = 'hookFailed'
 constkDefaultTimeout=null;
 constnoop=FunctionPrototype;
 constkShouldAbort=Symbol('kShouldAbort');
-constkFilename=process.argv?.[1];
 constkHookNames=ObjectSeal(['before','after','beforeEach','afterEach']);
 constkUnwrapErrors=newSafeSet()
 .add(kTestCodeFailure).add(kHookFailure)
@@ -508,7 +507,7 @@ class Test extends AsyncResource{
 this.diagnostic(warning);
 }
 
-if(loc===undefined||kFilename===undefined){
+if(loc===undefined){
 this.loc=undefined;
 }else{
 this.loc={

lib/internal/test_runner/utils.js

@@ -131,10 +131,9 @@ function tryBuiltinReporter(name){
 returnrequire(builtinPath);
 }
 
-functionshouldColorizeTestFiles(rootTest){
+functionshouldColorizeTestFiles(destinations){
 // This function assumes only built-in destinations (stdout/stderr) supports coloring
-const{ reporters, destinations }=parseCommandLine();
-returnArrayPrototypeSome(reporters,(_,index)=>{
+returnArrayPrototypeSome(destinations,(_,index)=>{
 constdestination=kBuiltinDestinations.get(destinations[index]);
 returndestination&&shouldColorize(destination);
 });