benchmark,test: refactoring

PR-URL: #26119 Refs: #26101 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: refack

benchmark/http/create-clientrequest.js

@@ -1,7 +1,9 @@
 'use strict';
 
 constcommon=require('../common.js');
-constClientRequest=require('http').ClientRequest;
+const{ ClientRequest }=require('http');
+constassert=require('assert');
+
 consttypes=Object.keys(common.urls)
 .filter((i)=>common.urls[i]
 .startsWith('http://'));
@@ -15,36 +17,43 @@ const bench = common.createBenchmark(main,{
 functionnoop(){}
 
 functionmain({url: type, arg, e }){
-e=+e;
+e=Number(e);
 constdata=common.bakeUrlData(type,e,false,false)
 .filter((i)=>i.startsWith('http://'));
 constlen=data.length;
-varresult;
-vari;
-if(arg==='options'){
-constoptions=data.map((i)=>({
-path: newURL(i).path,createConnection: noop
-}));
-bench.start();
-for(i=0;i<len;i++){
-result=newClientRequest(options[i]);
+letresult;
+switch(arg){
+case'options': {
+constoptions=data.map((i)=>({
+path: newURL(i).path,createConnection: noop
+}));
+bench.start();
+for(leti=0;i<len;i++){
+result=newClientRequest(options[i]);
+}
+bench.end(len);
+break;
+}
+case'URL': {
+constoptions=data.map((i)=>newURL(i));
+bench.start();
+for(leti=0;i<len;i++){
+result=newClientRequest(options[i],{createConnection: noop});
+}
+bench.end(len);
+break;
 }
-bench.end(len);
-}elseif(arg==='URL'){
-constoptions=data.map((i)=>newURL(i));
-bench.start();
-for(i=0;i<len;i++){
-result=newClientRequest(options[i],{createConnection: noop});
+case'string': {
+bench.start();
+for(leti=0;i<len;i++){
+result=newClientRequest(data[i],{createConnection: noop});
+}
+bench.end(len);
+break;
 }
-bench.end(len);
-}elseif(arg==='string'){
-bench.start();
-for(i=0;i<len;i++){
-result=newClientRequest(data[i],{createConnection: noop});
+default: {
+thrownewError(`Unknown arg type ${arg}`);
 }
-bench.end(len);
-}else{
-thrownewError(`Unknown arg type ${arg}`);
 }
-require('assert').ok(result);
+assert.ok(result);
 }

benchmark/http/headers.js

@@ -4,21 +4,20 @@ const common = require('../common.js');
 consthttp=require('http');
 
 constbench=common.createBenchmark(main,{
-duplicates: [1,100],
 n: [10,1000],
+len: [1,100],
 });
 
-functionmain({duplicates, n }){
+functionmain({len, n }){
 constheaders={
 'Connection': 'keep-alive',
 'Transfer-Encoding': 'chunked',
 };
 
-for(vari=0;i<n/duplicates;i++){
-headers[`foo${i}`]=[];
-for(varj=0;j<duplicates;j++){
-headers[`foo${i}`].push(`some header value ${i}`);
-}
+constIs=[ ...Array(n/len).keys()];
+constJs=[ ...Array(len).keys()];
+for(constiofIs){
+headers[`foo${i}`]=Js.map(()=>`some header value ${i}`);
 }
 
 constserver=http.createServer((req,res)=>{

benchmark/http/incoming_headers.js

@@ -5,10 +5,10 @@ const http = require('http');
 constbench=common.createBenchmark(main,{
 // unicode confuses ab on os x.
 c: [50,500],
-headerDuplicates: [0,5,20]
+n: [0,5,20]
 });
 
-functionmain({ c,headerDuplicates}){
+functionmain({ c,n}){
 constserver=http.createServer((req,res)=>{
 res.end();
 });
@@ -21,7 +21,7 @@ function main({c, headerDuplicates }){
 'Date': newDate().toString(),
 'Cache-Control': 'no-cache'
 };
-for(leti=0;i<headerDuplicates;i++){
+for(leti=0;i<n;i++){
 headers[`foo${i}`]=`some header value ${i}`;
 }
 bench.http({

test/benchmark/test-benchmark-http.js

@@ -14,23 +14,21 @@ const runBenchmark = require('../common/benchmark');
 runBenchmark('http',
 [
 'benchmarker=test-double-http',
-'c=1',
-'e=0',
-'url=long',
 'arg=string',
+'c=1',
 'chunkedEnc=true',
 'chunks=0',
 'dur=0.1',
-'duplicates=1',
+'e=0',
 'input=keep-alive',
 'key=""',
 'len=1',
 'method=write',
 'n=1',
 'res=normal',
 'type=asc',
+'url=long',
 'value=X-Powered-By',
-'headerDuplicates=1',
 ],
 {
 NODEJS_BENCHMARK_ZERO_ALLOWED: 1,