src: set thread name for main thread and v8 worker

PR-URL: #56416 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>

Author: RafaelGSS

src/node.cc

@@ -1165,6 +1165,7 @@ InitializeOncePerProcessInternal(const std::vector<std::string>& args,
  }
 
 if (!(flags & ProcessInitializationFlags::kNoInitializeNodeV8Platform)){
+uv_thread_setname("MainThread");
  per_process::v8_platform.Initialize(
 static_cast<int>(per_process::cli_options->v8_thread_pool_size));
  result->platform_ = per_process::v8_platform.Platform();

src/node_platform.cc

@@ -25,6 +25,7 @@ struct PlatformWorkerData{
 };
 
 staticvoidPlatformWorkerThread(void* data){
+uv_thread_setname("V8Worker");
  std::unique_ptr<PlatformWorkerData>
 worker_data(static_cast<PlatformWorkerData*>(data));
 

test/addons/uv-thread-name/binding.cc

@@ -0,0 +1,29 @@
+#include<node.h>
+#include<uv.h>
+#include<v8.h>
+
+using v8::FunctionCallbackInfo;
+using v8::Isolate;
+using v8::String;
+using v8::Value;
+
+voidGetThreadName(const FunctionCallbackInfo<Value>& args){
+ Isolate* isolate = args.GetIsolate();
+uv_thread_t thread;
+char thread_name[16];
+#ifdef _WIN32
+/* uv_thread_self isn't defined for the main thread on Windows. */
+ thread = GetCurrentThread();
+#else
+ thread = uv_thread_self();
+#endif
+uv_thread_getname(&thread, thread_name, sizeof(thread_name));
+ args.GetReturnValue().Set(
+String::NewFromUtf8(isolate, thread_name).ToLocalChecked());
+}
+
+voidinit(v8::Local<v8::Object> exports){
+NODE_SET_METHOD(exports, "getThreadName", GetThreadName);
+}
+
+NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, init)

test/addons/uv-thread-name/binding.gyp

@@ -0,0 +1,9 @@
+{
+'targets': [
+{
+'target_name': 'binding',
+'sources': [ 'binding.cc' ],
+'includes': ['../common.gypi'],
+ }
+ ]
+}

test/addons/uv-thread-name/test.js

@@ -0,0 +1,35 @@
+'use strict';
+constcommon=require('../../common');
+
+if(common.isAIX){
+common.skip('AIX is not supported by libuv');
+}
+
+constassert=require('node:assert');
+const{ parentPort, Worker, isMainThread }=require('node:worker_threads');
+constbindingPath=require.resolve(`./build/${common.buildType}/binding`);
+constbinding=require(bindingPath);
+
+if(isMainThread){
+assert.strictEqual(binding.getThreadName(),'MainThread');
+
+constworker=newWorker(__filename);
+worker.on('message',common.mustCall((data)=>{
+assert.strictEqual(data,'WorkerThread');
+}));
+worker.on('error',common.mustNotCall());
+worker.on('exit',common.mustCall((code)=>{
+assert.strictEqual(code,0);
+}));
+
+constnamedWorker=newWorker(__filename,{name: 'NamedThread'});
+namedWorker.on('message',common.mustCall((data)=>{
+assert.strictEqual(data,'NamedThread');
+}));
+namedWorker.on('error',common.mustNotCall());
+namedWorker.on('exit',common.mustCall((code)=>{
+assert.strictEqual(code,0);
+}));
+}else{
+parentPort.postMessage(binding.getThreadName());
+}