http: remove misleading warning

There are cases where the `'clientError'` event can be emitted multiple times, even if the socket is correctly destroyed. Fixes: #51073 PR-URL: #51204 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>

Author: lpinca

lib/_http_server.js

@@ -862,27 +862,12 @@ const requestChunkExtensionsTooLargeResponse = Buffer.from(
 'Connection: close\r\n\r\n','ascii',
 );
 
-functionwarnUnclosedSocket(){
-if(warnUnclosedSocket.emitted){
-return;
-}
-
-warnUnclosedSocket.emitted=true;
-process.emitWarning(
-'An error event has already been emitted on the socket. '+
-'Please use the destroy method on the socket while handling '+
-"a 'clientError' event.",
-);
-}
-
 functionsocketOnError(e){
 // Ignore further errors
 this.removeListener('error',socketOnError);
 
 if(this.listenerCount('error',noop)===0){
 this.on('error',noop);
-}else{
-warnUnclosedSocket();
 }
 
 if(!this.server.emit('clientError',e,this)){

test/parallel/test-http-server-multiple-client-error.js

@@ -0,0 +1,55 @@
+'use strict';
+constcommon=require('../common');
+
+// Test that the `'clientError'` event can be emitted multiple times even if the
+// socket is correctly destroyed and that no warning is raised.
+
+constassert=require('assert');
+consthttp=require('http');
+constnet=require('net');
+
+process.on('warning',common.mustNotCall());
+
+functionsocketListener(socket){
+constfirstByte=socket.read(1);
+if(firstByte===null){
+socket.once('readable',()=>{
+socketListener(socket);
+});
+return;
+}
+
+socket.unshift(firstByte);
+httpServer.emit('connection',socket);
+}
+
+constnetServer=net.createServer(socketListener);
+consthttpServer=http.createServer(common.mustNotCall());
+
+httpServer.once('clientError',common.mustCall((err,socket)=>{
+assert.strictEqual(err.code,'HPE_INVALID_METHOD');
+assert.strictEqual(err.rawPacket.toString(),'Q');
+socket.destroy();
+
+httpServer.once('clientError',common.mustCall((err)=>{
+assert.strictEqual(err.code,'HPE_INVALID_METHOD');
+assert.strictEqual(
+err.rawPacket.toString(),
+'WE http://example.com HTTP/1.1\r\n\r\n'
+);
+}));
+}));
+
+netServer.listen(0,common.mustCall(()=>{
+constsocket=net.createConnection(netServer.address().port);
+
+socket.on('connect',common.mustCall(()=>{
+socket.end('QWE http://example.com HTTP/1.1\r\n\r\n');
+}));
+
+socket.on('close',()=>{
+netServer.close();
+});
+
+socket.resume();
+}));

test/parallel/test-http-socket-error-listeners.js

@@ -1,5 +1,3 @@
-// Flags: --no-warnings
-
 'use strict';
 
 constcommon=require('../common');
@@ -17,7 +15,7 @@ const net = require('net');
 {
 leti=0;
 letsocket;
-process.on('warning',common.mustCall());
+process.on('warning',common.mustNotCall());
 
 constserver=http.createServer(common.mustNotCall());