http2: skip creating native ShutdownWrap

`ShutdownWrap` instances are being used to carry context between the start and the asynchronous end of shutting down the writable side of a `StreamBase`. HTTP/2 streams always perform this action synchronously, so no such object is necessary. PR-URL: #31283 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Author: addaleax

src/node_http2.cc

@@ -1987,6 +1987,12 @@ void Http2Stream::Close(int32_t code){
 Debug(this, "closed with code %d", code);
 }
 
+ShutdownWrap* Http2Stream::CreateShutdownWrap(v8::Local<v8::Object> object){
+// DoShutdown() always finishes synchronously, so there's no need to create
+// a structure to store asynchronous context.
+returnnullptr;
+}
+
 intHttp2Stream::DoShutdown(ShutdownWrap* req_wrap){
 if (IsDestroyed())
 return UV_EPIPE;

src/node_http2.h

@@ -472,6 +472,7 @@ class Http2Stream : public AsyncWrap,
 intReadStop() override;
 
 // Required for StreamBase
+ ShutdownWrap* CreateShutdownWrap(v8::Local<v8::Object> object) override;
 intDoShutdown(ShutdownWrap* req_wrap) override;
 
 boolHasWantsWrite() constoverride{returntrue}

src/stream_base-inl.h

@@ -162,7 +162,7 @@ inline int StreamBase::Shutdown(v8::Local<v8::Object> req_wrap_obj){
  ShutdownWrap* req_wrap = CreateShutdownWrap(req_wrap_obj);
 int err = DoShutdown(req_wrap);
 
-if (err != 0){
+if (err != 0 && req_wrap != nullptr){
  req_wrap->Dispose();
  }