console: optimize single-string logging

PR-URL: #60422 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Author: gurgunday

benchmark/console/log.js

@@ -0,0 +1,78 @@
+'use strict';
+
+// A console throughput benchmark.
+// Uses a custom Console with null Writable streams to avoid I/O latency.
+
+constcommon=require('../common.js');
+const{ Writable }=require('stream');
+const{ Console }=require('console');
+
+constbench=common.createBenchmark(main,{
+n: [2e6],
+variant: ['plain','format','object','group','info','warn','error'],
+});
+
+classNullextendsWritable{
+_write(chunk,enc,cb){cb();}
+}
+
+functionmakeConsole(){
+constdn=newNull();
+returnnewConsole({stdout: dn,stderr: dn,ignoreErrors: true,colorMode: false});
+}
+
+functionmain({ n, variant }){
+constc=makeConsole();
+
+switch(variant){
+case'plain': {
+bench.start();
+for(leti=0;i<n;i++)c.log('hello world');
+bench.end(n);
+break;
+}
+case'format': {
+bench.start();
+for(leti=0;i<n;i++)c.log('%s %d %j','a',42,{x: 1});
+bench.end(n);
+break;
+}
+case'object': {
+constobj={a: 1,b: 2,c: 3};
+bench.start();
+for(leti=0;i<n;i++)c.log(obj);
+bench.end(n);
+break;
+}
+case'group': {
+bench.start();
+for(leti=0;i<n;i++){
+c.group('g');
+c.log('x');
+c.groupEnd();
+}
+bench.end(n);
+break;
+}
+case'info': {
+bench.start();
+for(leti=0;i<n;i++)c.info('hello world');
+bench.end(n);
+break;
+}
+case'warn': {
+bench.start();
+for(leti=0;i<n;i++)c.warn('hello world');
+bench.end(n);
+break;
+}
+case'error': {
+bench.start();
+for(leti=0;i<n;i++)c.error('hello world');
+bench.end(n);
+break;
+}
+default:
+thrownewError('unknown variant');
+}
+}

lib/internal/console/constructor.js

@@ -190,7 +190,7 @@ ObjectDefineProperty(Console, SymbolHasInstance,{
 constkColorInspectOptions={colors: true};
 constkNoColorInspectOptions={};
 
-constinternalIndentationMap=newSafeWeakMap();
+constkGroupIndentationString=Symbol('kGroupIndentationString');
 
 ObjectDefineProperties(Console.prototype,{
 [kBindStreamsEager]: {
@@ -264,6 +264,11 @@ ObjectDefineProperties(Console.prototype,{
  ...consolePropAttributes,
 value: groupIndentation,
 },
+[kGroupIndentationString]: {
+__proto__: null,
+ ...consolePropAttributes,
+value: '',
+},
 [SymbolToStringTag]: {
 __proto__: null,
 writable: false,
@@ -279,7 +284,7 @@ ObjectDefineProperties(Console.prototype,{
  ...consolePropAttributes,
 value: function(streamSymbol,string){
 constignoreErrors=this._ignoreErrors;
-constgroupIndent=internalIndentationMap.get(this)||'';
+constgroupIndent=this[kGroupIndentationString];
 
 constuseStdout=streamSymbol===kUseStdout;
 conststream=useStdout ? this._stdout : this._stderr;
@@ -342,6 +347,14 @@ ObjectDefineProperties(Console.prototype,{
 __proto__: null,
  ...consolePropAttributes,
 value: function(args){
+if(args.length===1){
+// Fast path: single string, don't call format.
+// Avoids ReflectApply and validation overhead.
+consta0=args[0];
+if(typeofa0==='string'){
+returna0;
+}
+}
 constopts=this[kGetInspectOptions](this._stdout);
 ArrayPrototypeUnshift(args,opts);
 returnReflectApply(formatWithOptions,null,args);
@@ -351,6 +364,14 @@ ObjectDefineProperties(Console.prototype,{
 __proto__: null,
  ...consolePropAttributes,
 value: function(args){
+if(args.length===1){
+// Fast path: single string, don't call format.
+// Avoids ReflectApply and validation overhead.
+consta0=args[0];
+if(typeofa0==='string'){
+returna0;
+}
+}
 constopts=this[kGetInspectOptions](this._stderr);
 ArrayPrototypeUnshift(args,opts);
 returnReflectApply(formatWithOptions,null,args);
@@ -513,21 +534,20 @@ const consoleMethods ={
 ReflectApply(this.log,this,data);
 }
 
-letcurrentIndentation=internalIndentationMap.get(this)||'';
+letcurrentIndentation=this[kGroupIndentationString];
 currentIndentation+=StringPrototypeRepeat(' ',this[kGroupIndentationWidth]);
-
-internalIndentationMap.set(this,currentIndentation);
+this[kGroupIndentationString]=currentIndentation;
 },
 
 groupEnd(){
-constcurrentIndentation=internalIndentationMap.get(this)||'';
+constcurrentIndentation=this[kGroupIndentationString];
 constnewIndentation=StringPrototypeSlice(
 currentIndentation,
 0,
 currentIndentation.length-this[kGroupIndentationWidth],
 );
 
-internalIndentationMap.set(this,newIndentation);
+this[kGroupIndentationString]=newIndentation;
 },
 
 // https://console.spec.whatwg.org/#table