crypto: extract throwInvalidArgType function

This commit extracts the throwing of ERR_INVALID_ARG_TYPE which is done in identical ways in a few places in cipher.js. The motivation for this is that I think it improves readability enough to warrant a commit even though I'm aware that we should avoid commits with only these sort of refactoring. PR-URL: #22947 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Author: danbev

lib/internal/crypto/cipher.js

@@ -83,15 +83,19 @@ function createCipherBase(cipher, credential, options, decipher, iv){
 LazyTransform.call(this,options);
 }
 
+functioninvalidArrayBufferView(name,value){
+returnnewERR_INVALID_ARG_TYPE(
+name,
+['string','Buffer','TypedArray','DataView'],
+value
+);
+}
+
 functioncreateCipher(cipher,password,options,decipher){
 validateString(cipher,'cipher');
 password=toBuf(password);
 if(!isArrayBufferView(password)){
-thrownewERR_INVALID_ARG_TYPE(
-'password',
-['string','Buffer','TypedArray','DataView'],
-password
-);
+throwinvalidArrayBufferView('password',password);
 }
 
 createCipherBase.call(this,cipher,password,options,decipher);
@@ -101,20 +105,12 @@ function createCipherWithIV(cipher, key, options, decipher, iv){
 validateString(cipher,'cipher');
 key=toBuf(key);
 if(!isArrayBufferView(key)){
-thrownewERR_INVALID_ARG_TYPE(
-'key',
-['string','Buffer','TypedArray','DataView'],
-key
-);
+throwinvalidArrayBufferView('key',key);
 }
 
 iv=toBuf(iv);
 if(iv!==null&&!isArrayBufferView(iv)){
-thrownewERR_INVALID_ARG_TYPE(
-'iv',
-['string','Buffer','TypedArray','DataView'],
-iv
-);
+throwinvalidArrayBufferView('iv',iv);
 }
 createCipherBase.call(this,cipher,key,options,decipher,iv);
 }
@@ -149,11 +145,7 @@ Cipher.prototype.update = function update(data, inputEncoding, outputEncoding){
 outputEncoding=outputEncoding||encoding;
 
 if(typeofdata!=='string'&&!isArrayBufferView(data)){
-thrownewERR_INVALID_ARG_TYPE(
-'data',
-['string','Buffer','TypedArray','DataView'],
-data
-);
+throwinvalidArrayBufferView('data',data);
 }
 
 constret=this._handle.update(data,inputEncoding);