test: remove arbitrary timer

Trott · Trott · commit f99e6988557e · 2016-10-21T16:25:14.000-07:00
`test-dgram-send-callback-buffer-length` was timing out (via the 200ms timeout in the code) on FreeBSD in CI. The 200ms timeout is arbitrary and not necessary. Remove it. PR-URL: #9197 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/parallel/test-dgram-send-callback-buffer-length.js b/test/parallel/test-dgram-send-callback-buffer-length.js
@@ -6,18 +6,13 @@ const assert = require('assert');
 const dgram = require('dgram');
 const client = dgram.createSocket('udp4');
 
-const timer = setTimeout(function(){
- throw new Error('Timeout');
-}, common.platformTimeout(200));
-
 const buf = Buffer.allocUnsafe(256);
 const offset = 20;
 const len = buf.length - offset;
 
 const messageSent = common.mustCall(function messageSent(err, bytes){
- assert.notEqual(bytes, buf.length);
- assert.equal(bytes, buf.length - offset);
- clearTimeout(timer);
+ assert.notStrictEqual(bytes, buf.length);
+ assert.strictEqual(bytes, buf.length - offset);
 client.close();
 });
 

-Original file line number
+Diff line change
 constdgram=require('dgram');
 constclient=dgram.createSocket('udp4');
 -consttimer=setTimeout(function(){
 -thrownewError('Timeout');
 -},common.platformTimeout(200));
+-
 constbuf=Buffer.allocUnsafe(256);
 constoffset=20;
 constlen=buf.length-offset;
 constmessageSent=common.mustCall(functionmessageSent(err,bytes){
 -assert.notEqual(bytes,buf.length);
 -assert.equal(bytes,buf.length-offset);
 -clearTimeout(timer);
 +assert.notStrictEqual(bytes,buf.length);
 +assert.strictEqual(bytes,buf.length-offset);
 client.close();
 });