test: fix flaky test-http2-client-upload

Wait for close event on server stream before shuting down server and client to avoid races seen on windows CI. Refs: #20750 (comment) PR-URL: #29889 Refs: #29852 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: Flarna

test/parallel/test-http2-client-upload.js

@@ -21,24 +21,29 @@ fs.readFile(loc, common.mustCall((err, data) =>{
 fileData=data;
 
 constserver=http2.createServer();
+letclient;
+
+constcountdown=newCountdown(3,()=>{
+server.close();
+client.close();
+});
 
 server.on('stream',common.mustCall((stream)=>{
 letdata=Buffer.alloc(0);
 stream.on('data',(chunk)=>data=Buffer.concat([data,chunk]));
 stream.on('end',common.mustCall(()=>{
 assert.deepStrictEqual(data,fileData);
 }));
+// Waiting on close avoids spurious ECONNRESET seen in windows CI.
+// Not sure if this is actually a bug; more details at
+// https://github.com/nodejs/node/issues/20750#issuecomment-511015247
+stream.on('close',()=>countdown.dec());
 stream.respond();
 stream.end();
 }));
 
 server.listen(0,common.mustCall(()=>{
-constclient=http2.connect(`http://localhost:${server.address().port}`);
-
-constcountdown=newCountdown(2,()=>{
-server.close();
-client.close();
-});
+client=http2.connect(`http://localhost:${server.address().port}`);
 
 constreq=client.request({':method': 'POST'});
 req.on('response',common.mustCall());