tools: update ESLint to current version

We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: #10561 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>

Author: Trott

.eslintrc.yaml

@@ -83,7 +83,12 @@ rules:
 computed-property-spacing: 2
 eol-last: 2
 func-call-spacing: 2
-indent: [2, 2,{SwitchCase: 1, MemberExpression: 1}]
+func-name-matching: 2
+indent: [2, 2,{ArrayExpression: first,
+CallExpression: {arguments: first},
+MemberExpression: 1,
+ObjectExpression: first,
+SwitchCase: 1}]
 key-spacing: [2,{mode: minimum}]
 keyword-spacing: 2
 linebreak-style: [2, unix]

benchmark/common.js

@@ -58,7 +58,7 @@ function runBenchmarks(){
 if(!test)
 return;
 
-if(test.match(/^[\._]/))
+if(test.match(/^[._]/))
 returnprocess.nextTick(runBenchmarks);
 
 if(outputFormat=='default')
@@ -86,7 +86,7 @@ function Benchmark(fn, options){
 this.fn=fn;
 this.options=options;
 this.config=parseOpts(options);
-this._name=require.main.filename.split(/benchmark[\/\\]/).pop();
+this._name=require.main.filename.split(/benchmark[/\\]/).pop();
 this._start=[0,0];
 this._started=false;
 
@@ -101,7 +101,7 @@ function Benchmark(fn, options){
 Benchmark.prototype.http=function(p,args,cb){
 hasWrk();
 varself=this;
-varregexp=/Requests\/sec:[\t]+([0-9\.]+)/;
+varregexp=/Requests\/sec:[\t]+([0-9.]+)/;
 varurl='http://127.0.0.1:'+exports.PORT+p;
 
 args=args.concat(url);

lib/fs.js

@@ -74,7 +74,7 @@ try{
 printDeprecation('fs: re-evaluating native module sources is not '+
 'supported. If you are using the graceful-fs module, '+
 'please update it to a more recent version.',
-false);
+false);
 }
 
 functionthrowOptionsError(options){

lib/internal/process.js

@@ -141,6 +141,7 @@ function setupConfig(_source){
 Intl.hasOwnProperty('v8BreakIterator')&&
 !process.icu_data_dir){
 constdes=Object.getOwnPropertyDescriptor(Intl,'v8BreakIterator');
+// eslint-disable-next-line func-name-matching
 des.value=functionv8BreakIterator(){
 thrownewError('v8BreakIterator: full ICU data not installed. '+
 'See https://github.com/nodejs/node/wiki/Intl');

lib/readline.js

@@ -1102,17 +1102,20 @@ function codePointAt(str, index){
 }
 returncode;
 }
-exports.codePointAt=internalUtil.deprecate(codePointAt,
-'readline.codePointAt is deprecated. '+
-'Use String.prototype.codePointAt instead.');
+exports.codePointAt=internalUtil.deprecate(
+codePointAt,
+'readline.codePointAt is deprecated. '+
+'Use String.prototype.codePointAt instead.');
 
 
-exports.getStringWidth=internalUtil.deprecate(getStringWidth,
-'getStringWidth is deprecated and will be removed.');
+exports.getStringWidth=internalUtil.deprecate(
+getStringWidth,
+'getStringWidth is deprecated and will be removed.');
 
 
-exports.isFullWidthCodePoint=internalUtil.deprecate(isFullWidthCodePoint,
-'isFullWidthCodePoint is deprecated and will be removed.');
+exports.isFullWidthCodePoint=internalUtil.deprecate(
+isFullWidthCodePoint,
+'isFullWidthCodePoint is deprecated and will be removed.');
 
 
 exports.stripVTControlCharacters=internalUtil.deprecate(

lib/url.js

@@ -41,7 +41,7 @@ const portPattern = /:[0-9]*$/;
 consthostPattern=/^\/\/[^@/]+@[^@/]+/;
 
 // Special case for a simple path URL
-constsimplePathPattern=/^(\/\/?(?!\/)[^\?\s]*)(\?[^\s]*)?$/;
+constsimplePathPattern=/^(\/\/?(?!\/)[^?\s]*)(\?[^\s]*)?$/;
 
 consthostnameMaxLen=255;
 // protocols that can allow "unsafe" and "unwise" chars.

test/parallel/test-child-process-exec-timeout.js

@@ -39,9 +39,9 @@ cp.exec(cmd,{
 
 // Test the case where a timeout is set, but not expired.
 cp.exec(cmd,{timeout: Math.pow(2,30)},
-common.mustCall((err,stdout,stderr)=>{
-assert.ifError(err);
-assert.strictEqual(stdout.trim(),'child stdout');
-assert.strictEqual(stderr.trim(),'child stderr');
-})
+common.mustCall((err,stdout,stderr)=>{
+assert.ifError(err);
+assert.strictEqual(stdout.trim(),'child stdout');
+assert.strictEqual(stderr.trim(),'child stderr');
+})
 );

tools/doc/html.js

@@ -91,7 +91,7 @@ function loadGtoc(cb){
 functiontoID(filename){
 returnfilename
 .replace('.html','')
-.replace(/[^\w\-]/g,'-')
+.replace(/[^\w-]/g,'-')
 .replace(/-+/g,'-');
 }
 
@@ -309,7 +309,7 @@ function linkJsTypeDocs(text){
 // Handle types, for example the source Markdown might say
 // "This argument should be a{Number} or{String}"
 for(i=0;i<parts.length;i+=2){
-typeMatches=parts[i].match(/\{([^\}]+)\}/g);
+typeMatches=parts[i].match(/\{([^}]+)\}/g);
 if(typeMatches){
 typeMatches.forEach(function(typeMatch){
 parts[i]=parts[i].replace(typeMatch,typeParser.toLink(typeMatch));

tools/doc/json.js

@@ -31,7 +31,7 @@ function doJSON(input, filename, cb){
 // <!-- type = module -->
 // This is for cases where the markdown semantic structure is lacking.
 if(type==='paragraph'||type==='html'){
-varmetaExpr=/<!--([^=]+)=([^\-]+)-->\n*/g;
+varmetaExpr=/<!--([^=]+)=([^-]+)-->\n*/g;
 text=text.replace(metaExpr,function(_0,k,v){
 current[k.trim()]=v.trim();
 return'';
@@ -371,7 +371,7 @@ function parseListItem(item){
 item.name='return';
 text=text.replace(retExpr,'');
 }else{
-varnameExpr=/^['`"]?([^'`":\{]+)['`"]?\s*:?\s*/;
+varnameExpr=/^['`"]?([^'`":{]+)['`"]?\s*:?\s*/;
 varname=text.match(nameExpr);
 if(name){
 item.name=name[1];
@@ -388,7 +388,7 @@ function parseListItem(item){
 }
 
 text=text.trim();
-vartypeExpr=/^\{([^\}]+)\}/;
+vartypeExpr=/^\{([^}]+)\}/;
 vartype=text.match(typeExpr);
 if(type){
 item.type=type[1];
@@ -546,12 +546,12 @@ function deepCopy_(src){
 vareventExpr=/^Event(?::|\s)+['"]?([^"']+).*$/i;
 varclassExpr=/^Class:\s*([^]+).*?$/i;
 varpropExpr=/^(?:property:?\s*)?[^.]+\.([^.()]+)\s*?$/i;
-varbraceExpr=/^(?:property:?\s*)?[^.\[]+(\[[^\]]+\])\s*?$/i;
+varbraceExpr=/^(?:property:?\s*)?[^.[]+(\[[^\]]+\])\s*?$/i;
 varclassMethExpr=
 /^class\s*method\s*:?[^.]+\.([^.()]+)\([^)]*\)\s*?$/i;
 varmethExpr=
 /^(?:method:?\s*)?(?:[^.]+\.)?([^.()]+)\([^)]*\)\s*?$/i;
-varnewExpr=/^new([A-Z][a-zA-Z]+)\([^\)]*\)\s*?$/;
+varnewExpr=/^new([A-Z][a-zA-Z]+)\([^)]*\)\s*?$/;
 varparamExpr=/\((.*)\);?$/;
 
 functionnewSection(tok){

tools/eslint/LICENSE

@@ -1,5 +1,5 @@
 ESLint
-Copyright jQuery Foundation and other contributors, https://jquery.org/
+Copyright JS Foundation and other contributors, https://js.foundation
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal