wasi: use missing validator

The `wasi` lib module's `initialize()` method is missing a validator. PR-URL: #39070 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

Author: VoltrexKeyva

lib/internal/validators.js

@@ -229,6 +229,11 @@ const validateFunction = hideStackFrames((value, name) =>{
 thrownewERR_INVALID_ARG_TYPE(name,'Function',value);
 });
 
+constvalidateUndefined=hideStackFrames((value,name)=>{
+if(value!==undefined)
+thrownewERR_INVALID_ARG_TYPE(name,'undefined',value);
+});
+
 module.exports={
  isInt32,
  isUint32,
@@ -247,6 +252,7 @@ module.exports ={
  validateSignalName,
  validateString,
  validateUint32,
+ validateUndefined,
  validateCallback,
  validateAbortSignal,
 };

lib/wasi.js

@@ -21,6 +21,7 @@ const{
  validateFunction,
  validateInt32,
  validateObject,
+ validateUndefined,
 }=require('internal/validators');
 const{WASI: _WASI}=internalBinding('wasi');
 constkExitCode=Symbol('kExitCode');
@@ -120,10 +121,7 @@ class WASI{
 const{ _start, _initialize }=this[kInstance].exports;
 
 validateFunction(_start,'instance.exports._start');
-if(_initialize!==undefined){
-thrownewERR_INVALID_ARG_TYPE(
-'instance.exports._initialize','undefined',_initialize);
-}
+validateUndefined(_initialize,'instance.exports._initialize');
 
 try{
 _start();
@@ -147,16 +145,9 @@ class WASI{
 
 const{ _start, _initialize }=this[kInstance].exports;
 
-if(typeof_initialize!=='function'&&_initialize!==undefined){
-thrownewERR_INVALID_ARG_TYPE(
-'instance.exports._initialize','function',_initialize);
-}
-if(_start!==undefined){
-thrownewERR_INVALID_ARG_TYPE(
-'instance.exports._start','undefined',_initialize);
-}
-
+validateUndefined(_start,'instance.exports._start');
 if(_initialize!==undefined){
+validateFunction(_initialize,'instance.exports._initialize');
 _initialize();
 }
 }

test/wasi/test-wasi-initialize-validation.js

@@ -78,7 +78,8 @@ const bufferSource = fixtures.readSync('simple.wasm');
 ()=>{wasi.initialize(instance);},
 {
 code: 'ERR_INVALID_ARG_TYPE',
-message: /"instance\.exports\._start"propertymustbeundefined/
+message: 'The "instance.exports._start" property must be'+
+' undefined. Received function _start',
 }
 );
 }

test/wasi/test-wasi-start-validation.js

@@ -78,7 +78,8 @@ const bufferSource = fixtures.readSync('simple.wasm');
 ()=>{wasi.start(instance);},
 {
 code: 'ERR_INVALID_ARG_TYPE',
-message: /"instance\.exports\._initialize"propertymustbeundefined/
+message: 'The "instance.exports._initialize" property must be'+
+' undefined. Received function _initialize',
 }
 );
 }