Skip to content

Conversation

@wraithgar
Copy link
Member

@wraithgarwraithgar commented Feb 7, 2023

This is a total rebuild of the package-lock. The diff of the
package-lock was audited line by line and changes were assessed. In all
but one case the only changes were semver-compatible bumps of
subdependencies, and a shuffling of the hoisting of some dev
dependencies (which don't affect the published package).

The only package that had to be manually re-hoisted was
normalize-package-data. This was done by installing then uninstalling
the version we wanted hoisted (in this case it was semver major version
5).

@wraithgarwraithgar requested a review from a team as a code ownerFebruary 7, 2023 19:10
@wraithgarwraithgar requested review from fritzy and removed request for a teamFebruary 7, 2023 19:10
Copy link
Contributor

@lukekarryslukekarrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changed files in workspaces/arborist/test/fixtures/ were moved in 4c5bd6e and probably got re-added in this PR. Can those be removed?

This is a total rebuild of the package-lock. The diff of the package-lock was audited line by line and changes were assessed. In all but one case the only changes were semver-compatible bumps of subdependencies, and a shuffling of the hoisting of some dev dependencies (which don't affect the published package). The only package that had to be manually re-hoisted was `normalize-package-data`. This was done by installing then uninstalling the version we wanted hoisted (in this case it was semver major version 5).
@lukekarryslukekarrys merged commit cb6713d into latestFeb 7, 2023
@lukekarryslukekarrys deleted the gar/lock-test branch February 7, 2023 19:41
@github-actionsgithub-actionsbot mentioned this pull request Feb 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wraithgar@lukekarrys