Change-Id: Ib0377b5c9ca8ec264a81173835580d6bb6c4b3e4

Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/2024.2 branch, tests will continue to use the upper-constraints list on master. Change-Id: I23254d63d6f87a11e1b633ac7f7756f46625533d

The parameter is called admin_password on the SDK side. Change-Id: I0cd86675a884e6c2cbd3a861b8e111f961f0f336 (cherry picked from commit 8932282)

Change I0cd86675a884e6c2cbd3a861b8e111f961f0f336 was incorrect, the SDK param name is admin_pass. Change-Id: Ibe22c3d7d7ba0f1a5178475143e35fee5cac2ca2 (cherry picked from commit 58d1b06)

In change I06f3848812bce60c65909f1311f36b70eba427d4, we migrated the 'user *' commands from keystoneclient to SDK. One side effect of this is that we are no longer able to rely on keystoneclient's 'filter_none' helper method that filters out parameters that are set to None. As such, we now need to do this ourselves. Eventually, it would be nice if SDK provided such functionality itself. The same change also introduced a bug where the '--domain' argument was being used to lookup a project rather than the '--project-domain' argument. This is also corrected. Change-Id: I1204ca611a74d134c879467d6c2b73f16e043213 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Closes-bug: #2080600 (cherry picked from commit 033793a)

… it is None Currently, it is passing None value which is not accepted by keystone parameters validation: BadRequestException: 400: Client Error for url: ... Invalid input for field 'enabled': None is not of type 'boolean' Failed validating 'type' in schema['properties']['enabled']:{'enum': [True, False, None], 'type': 'boolean'} On instance['enabled']: None Closes-Bug: #2083021 Change-Id: Ia8772560deb54e71672102157659d4eb22e6ad59

…on when it is None" into stable/2024.2

The --user-domain option and the --project-domain option may take id or name. In case name is given it should be translated to id. Closes-Bug: 2083390 Change-Id: Idf3f113a74452daabc80660574030cb9b24b1a15

With `openstacksdk` 3.2.0 the `host` attribute of an Instance got added to the `Server` class [0]. With that change, listing servers with the `host` attribute leads to a query-filter for `compute_host` as expected, but `openstacksdk` will also filter for the `host` attribute locally after the results are returned. Since `compute_host` being `OS-EXT-SRV-ATTR:host` is not the same as `host, this means no results are returned. Since we want to keep the old behaviour of filtering by `compute_host` i.e. the service host name, we need to switch to filter for `compute_host`. This is already supported in older versions of `openstacksdk`. [0] openstack/openstacksdk@0f311ff Change-Id: I0cd32c5b7d6d4d21194f3efdcfb9b205dea6a91e Closes-bug: #2074200 (cherry picked from commit ffa683a)

…stable/2024.2

This is a fun one driven by two separate changes. We recently started checking whether the volume service was available before setting quotas in order to allow us to use quota set for other services [1]. This merged a number of weeks ago and was included in 7.1.0. More recently, we modified DevStack to stop publishing a service catalog entry with a service type of 'volumev3', preferring instead to use the correct 'block-storage' service type. Taken separately, neither of these changes would have caused issues. Together, they mean our lookups for the volume service now fail and we can't set volume quotas. Fix things by checking for the block-storage service type also. A future change will raise a warning (later an error) if the volume service is not found and you're attempting to set a quota since this is clearly a mistake. Change-Id: Ibbeef52225e18757cd28d0fbfb14c1ca06975b60 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Closes-bug: #2084580 (cherry picked from commit 7c6b47b)

Fix the wrong value assignment which made the --user-domain option ignored. Unit tests are updated to verify usage of domain options to avoid further regressions. Also drop the redundant look up of domain id to avoid unnecessary API call. Closes-Bug: #2085604 Change-Id: I5112b8e831fb26eb6544615277f0d3fe4f15dc5a (cherry picked from commit 2e49119)

The sooner we have type hints in SDK, the better /o\ Change-Id: Iaf9596aea02f683c280ae68504a14d43dbd6134a Closes-bug: #2077634 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit e5ccf1e)

…24.2

There is a flaw (IMO) in the design of Nova's os-quota-sets API: despite project IDs forming the identifier for an individual resource, we get a HTTP 400 (Bad Request) error if you pass an ID that does not exist, rather than the HTTP 404 (Not Found) we would expect. Correct this, noting why we're doing what we're doing for readers from the future (hi!). Note that HTTP 400 is unfortunately quite broad and means we'll also catch things like invalid requests but the exception may have been translated so we can't rely on a string match. Change-Id: I720502930d50be8ead5f2033d9dbcab5d99a37a9 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Closes-bug: #2091086 (cherry picked from commit 99cef93)

We may need to remove this soon enough, given the new Docker rate limits that we keep bumping into. Change-Id: Id4a9d8df770d107986b20e4a98835ee4e0b6117d Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit 7ef588d) (cherry picked from commit 94fe341)

By passing a dict instead of a single value, we force SDK to populate the correct attribute on the object. Also fixed conflicts in openstackclient/compute/v2/server.py added by ece30e8 Change-Id: I9f4c5964dc0546215474c92db567966ffad68a1a Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Related-bug: #2089821 (cherry picked from commit 22b30b9)

The fix is in openstacksdk. Let's test it here though. Change-Id: I661e6d66c8196e8c9ca8b9cda3d08e756e3d5877 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/963945 Related-bug: #2089821 (cherry picked from commit e736394)