Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository:ParallelSSH/ssh-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base:master
Choose a base ref
...
head repository:parallel-ssh/ssh-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare:master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 16 commits
  • 176 files changed
  • 2 contributors

Commits on Jul 23, 2023

  1. appveyor: generate pep440 compliant version in fix_version.py

    I'm unsure if this script is still needed.
    @enkore
    enkore authored Jul 23, 2023
    Configuration menu
    Copy the full SHA
    3a7b14eView commit details
    Browse the repository at this point in the history
  2. libssh 0.10.5 (#72)

    @enkore
    enkore authored Jul 23, 2023
    Configuration menu
    Copy the full SHA
    70d49b1View commit details
    Browse the repository at this point in the history
  3. versioneer: replace deprecated (and removed in 3.12) SafeConfigParser (

    …#71) * versioneer: replace deprecated (and removed in 3.12) SafeConfigParser See for details: https://github.com/python/cpython/pull/92503/files * versioneer: replace as well deprecated readfp with read_file
    @fedepell
    fedepell authored Jul 23, 2023
    Configuration menu
    Copy the full SHA
    7ab1db2View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    abba89dView commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b11c02cView commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f5505f8View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a2ad47dView commit details
    Browse the repository at this point in the history
  8. drop cpython 3.6

    @enkore
    enkore committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    c3f0d7bView commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Merge pull request#1from parallel-ssh/next

    ssh-python next
    @enkore
    enkore authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5cdc87fView commit details
    Browse the repository at this point in the history
  2. session: un-noop disconnect

    @enkore
    enkore committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2ead93dView commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1505cb3View commit details
    Browse the repository at this point in the history
  4. drop Python 3.7 (EOL)

    @enkore
    enkore committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1b0cd2aView commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. session: disconnect on __dealloc__

    calling ssh_disconnect means the Session object is still around which means Channel objects may still be around, but ssh_disonnects also performs ssh_channel_do_free on any open channels, which makes those Channel._channel pointers dangling pointers. This causes a UAF when Channel.__dealloc__ runs where (if the memory wasn't reclaimed, which is likely) _channel->session is nulled in the session->alive check in ssh_channel_free. Because we can't fix this, this effectively means that Session.disconnect CANNOT be implemented as an API. However, if we instead do the disconnect in Session.__dealloc__, then this can't happen, as the Channel._session reference forces Channel objects to be deallocd before the Session. Another fix could be for ssh_channel_free to check both channel and channel->session for NULL (currently does the former), but this would only mask the crash in most instances and not actually fix the UAF.
    @enkore
    enkore committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f5a451eView commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5759e3fView commit details
    Browse the repository at this point in the history
  3. manylinux2014: remove krb5

    @enkore
    enkore committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    3f549f5View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    732f135View commit details
    Browse the repository at this point in the history
Loading