Discussion: errors from new rules when updating eslint-config-airbnb to v19 #2657
lindapaiste started this conversation in General
Replies: 0 comments
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Increasing Access
It's good to keep all of our dependencies updated to their latest versions.
Feature enhancement details
We us the
eslint-config-airbnbpackage to define a lot of our code style rules. We are currently on version16.1.0. I would like to update this to the latest version19.0.4. This update changes a lot of rules and introduces LOTS of linting errors into the codebase:For each rule, we have 3 options:
.eslintrcconfig to allow the current code.lint-fixcommand)..eslintrcto downgrade errors to warnings.My plan right now is to update the package but add exemptions for all of the rules (option 1).
I don't like to change to much in a single PR so my plan is to address desirable rules (option 2) individually. For example I think that
no-useless-catchis a good rule which we should use so I put in PR #2212 to fix the code.Here are examples of all of the new errors:
Object.assigneg:{...foo }+must be placed on a new lineBetaWas this translation helpful?Give feedback.
All reactions