bpo-1635741: Port resource extension module to module state (GH-23462)

Signed-off-by: Christian Heimes <christian@python.org>

Author: tiran

Misc/NEWS.d/next/C API/2020-11-22-13-46-06.bpo-1635741.-fJLzA.rst

@@ -0,0 +1 @@
+Port :mod:`resource` extension module to module state

Modules/resource.c

@@ -63,8 +63,20 @@ static PyStructSequence_Desc struct_rusage_desc ={
 16/* n_in_sequence */
 };
 
-staticintinitialized;
-staticPyTypeObjectStructRUsageType;
+typedefstruct{
+PyTypeObject*StructRUsageType;
+} resourcemodulestate;
+
+
+staticinlineresourcemodulestate*
+get_resource_state(PyObject*module)
+{
+void*state=PyModule_GetState(module);
+assert(state!=NULL);
+return (resourcemodulestate*)state;
+}
+
+staticstructPyModuleDefresourcemodule;
 
 /*[clinic input]
 resource.getrusage
@@ -91,7 +103,8 @@ resource_getrusage_impl(PyObject *module, int who)
 returnNULL;
  }
 
-result=PyStructSequence_New(&StructRUsageType);
+result=PyStructSequence_New(
+get_resource_state(module)->StructRUsageType);
 if (!result)
 returnNULL;
 
@@ -336,10 +349,10 @@ resource_methods[] ={
 
 /* Module initialization */
 
-
 staticint
 resource_exec(PyObject*module)
 {
+resourcemodulestate*state=get_resource_state(module);
 #defineADD_INT(module, value) \
  do{\
  if (PyModule_AddIntConstant(module, #value, value) < 0){\
@@ -353,13 +366,12 @@ resource_exec(PyObject *module)
 Py_DECREF(PyExc_OSError);
 return-1;
  }
-if (!initialized){
-if (PyStructSequence_InitType2(&StructRUsageType,
-&struct_rusage_desc) <0)
-return-1;
- }
 
-if(PyModule_AddType(module, &StructRUsageType) <0){
+state->StructRUsageType=PyStructSequence_NewType(&struct_rusage_desc);
+if (state->StructRUsageType==NULL){
+return-1;
+ }
+if (PyModule_AddType(module, state->StructRUsageType) <0){
 return-1;
  }
 
@@ -483,8 +495,6 @@ resource_exec(PyObject *module)
 Py_DECREF(v);
 return-1;
  }
-
-initialized=1;
 return0;
 
 #undef ADD_INT
@@ -495,12 +505,32 @@ static struct PyModuleDef_Slot resource_slots[] ={
 {0, NULL}
 };
 
+staticint
+resourcemodule_traverse(PyObject*m, visitprocvisit, void*arg){
+Py_VISIT(get_resource_state(m)->StructRUsageType);
+return0;
+}
+
+staticint
+resourcemodule_clear(PyObject*m){
+Py_CLEAR(get_resource_state(m)->StructRUsageType);
+return0;
+}
+
+staticvoid
+resourcemodule_free(void*m){
+resourcemodule_clear((PyObject*)m);
+}
+
 staticstructPyModuleDefresourcemodule={
 PyModuleDef_HEAD_INIT,
  .m_name="resource",
- .m_size=0,
+ .m_size=sizeof(resourcemodulestate),
  .m_methods=resource_methods,
  .m_slots=resource_slots,
+ .m_traverse=resourcemodule_traverse,
+ .m_clear=resourcemodule_clear,
+ .m_free=resourcemodule_free,
 };
 
 PyMODINIT_FUNC