gh-127930: use explicit imports in tkinter.simpledialog (#127931)

tungol · picnixz · web-flow · commit 81bfcf1aaef4 · 2025-12-14T12:38:42.000+02:00
Co-authored-by: Bénédikt Tran &lt;10796600+picnixz@users.noreply.github.com&gt;
diff --git a/Lib/tkinter/simpledialog.py b/Lib/tkinter/simpledialog.py
@@ -23,9 +23,12 @@
 askstring -- get a string from the user
 """
 
-from tkinter import *
+from tkinter import Button, Entry, Frame, Label, Message, Tk, Toplevel
 from tkinter import _get_temp_root, _destroy_temp_root
 from tkinter import messagebox
+from tkinter.constants import ACTIVE, BOTH, END, LEFT, RIDGE, W, E
+
+__all__ = ["SimpleDialog", "Dialog", "askinteger", "askfloat", "askstring"]
 
 
 class SimpleDialog:
diff --git a/Misc/NEWS.d/next/Library/2024-12-14-19-51-39.gh-issue-127930.WsGnh9.rst b/Misc/NEWS.d/next/Library/2024-12-14-19-51-39.gh-issue-127930.WsGnh9.rst
@@ -0,0 +1 @@
+Add ``__all__`` to :mod:`tkinter.simpledialog`.

-Original file line number
+Diff line change
 askstring -- get a string from the user
 """
 -fromtkinterimport*
 +fromtkinterimportButton, Entry, Frame, Label, Message, Tk, Toplevel
 fromtkinterimport_get_temp_root, _destroy_temp_root
 fromtkinterimportmessagebox
 +fromtkinter.constantsimportACTIVE, BOTH, END, LEFT, RIDGE, W, E
++
 +__all__= ["SimpleDialog", "Dialog", "askinteger", "askfloat", "askstring"]
 classSimpleDialog:
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Add ``__all__`` to :mod:`tkinter.simpledialog`.