Skip to content

Commit f1346c1

Browse files
xxtanisxxSaitejaTammamarkmandel
committed
Fix annotations on allocationApiService, validatingWebhook, mutatingWebhook (googleforgames#2528)
* Release v1.22.0 rc (googleforgames#2519) * release v1.22.0-rc * Re-generated Install.yaml * Changes on new release.md file * Update site/content/en/blog/releases/1.22.0-rc Co-authored-by: Mark Mandel <[email protected]> * Changes * updated and renamed the md file * regenerated changelog file * changes for md and changelog files Co-authored-by: Mark Mandel <[email protected]> * Fix annotations * Fix documentations * Add custom secret * Update documentations * minor Co-authored-by: SaitejaTamma <[email protected]> Co-authored-by: Mark Mandel <[email protected]>
1 parent 3f00aa6 commit f1346c1

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

‎install/helm/agones/templates/controller.yaml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,10 @@ spec:
159159
- name: certs
160160
secret:
161161
secretName: {{template "agones.fullname" . }}-cert
162+
{{- if .Values.agones.controller.customCertSecretPath }}
163+
items:
164+
{{- toYaml .Values.agones.controller.customCertSecretPath | nindent 10 }}
165+
{{- end }}
162166
{{- if .Values.agones.controller.persistentLogs }}
163167
- name: logs
164168
emptyDir: {}

‎install/helm/agones/templates/extensions.yaml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ metadata:
3030
heritage: {{.Release.Service }}
3131
{{- if .Values.agones.controller.allocationApiService.annotations }}
3232
annotations:
33-
{{- toYaml .Values.agones.controller.allocationApiService.annotations | indent 4 }}
33+
{{- toYaml .Values.agones.controller.allocationApiService.annotations | nindent 4 }}
3434
{{- end }}
3535
spec:
3636
group: allocation.agones.dev
@@ -56,7 +56,7 @@ metadata:
5656
name: agones-validation-webhook
5757
{{- if .Values.agones.controller.validatingWebhook.annotations }}
5858
annotations:
59-
{{- toYaml .Values.agones.controller.validatingWebhook.annotations | indent 4 }}
59+
{{- toYaml .Values.agones.controller.validatingWebhook.annotations | nindent 4 }}
6060
{{- end }}
6161
labels:
6262
component: controller
@@ -119,7 +119,7 @@ metadata:
119119
name: agones-mutation-webhook
120120
{{- if .Values.agones.controller.mutatingWebhook.annotations }}
121121
annotations:
122-
{{- toYaml .Values.agones.controller.mutatingWebhook.annotations | indent 4 }}
122+
{{- toYaml .Values.agones.controller.mutatingWebhook.annotations | nindent 4 }}
123123
{{- end }}
124124
labels:
125125
component: controller

‎install/helm/agones/values.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ agones:
7777
mutatingWebhook:
7878
annotations: {}
7979
disableCaBundle: false
80+
customCertSecretPath: {}
8081
safeToEvict: false
8182
persistentLogs: true
8283
persistentLogsSizeLimitMB: 10000

‎site/content/en/docs/Installation/Install Agones/helm.md‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ The following tables lists the configurable parameters of the Agones chart and t
210210
| --------------------------------------------------- | ----------------------------------------------------------------------------------------------- | ---------------------- |
211211
||||
212212
|`agones.controller.disableSecret`| Disables the creation of any allocator secrets. If true, you MUST provide the `{agones.releaseName}-cert` secrets before installation. |`false`|
213+
|`agones.controller.customCertSecretPath`| Remap cert-manager path to server.crt and server.key |`{}`|
213214
|`agones.controller.allocationApiService.annotations`|[Annotations][annotations] added to the Agones apiregistration |`{}`|
214215
|`agones.controller.allocationApiService.disableCaBundle`| Disable ca-bundle so it can be injected by cert-manager |`false`|
215216
|`agones.controller.validatingWebhook.annotations`|[Annotations][annotations] added to the Agones validating webhook |`{}`|
@@ -324,7 +325,7 @@ metadata:
324325
name: my-release-cert
325326
namespace: agones-system
326327
spec:
327-
ipAddresses:
328+
dnsNames:
328329
- agones-controller-service.agones-system.svc
329330
secretName: my-release-cert
330331
issuerRef:
@@ -338,6 +339,9 @@ After the certificates are generated, we will want to [inject caBundle](https://
338339
```bash
339340
helm install my-release \
340341
--set agones.controller.disableSecret=true \
342+
--set agones.controller.customCertSecretPath[0].key='ca.crt',customCertSecretPath[0].path='ca.crt'
343+
--set agones.controller.customCertSecretPath[1].key='tls.crt',customCertSecretPath[1].path='server.crt'
344+
--set agones.controller.customCertSecretPath[2].key='tls.key',customCertSecretPath[2].path='server.key'
341345
--set agones.controller.allocationApiService.annotations={'cert-manager.io/inject-ca-from': 'agones-system/my-release-cert'} \
342346
--set agones.controller.allocationApiService.disableCaBundle=true \
343347
--set agones.controller.validatingWebhook.annotations={'cert-manager.io/inject-ca-from': 'agones-system/my-release-cert'} \

0 commit comments

Comments
(0)