[refactor] better modal heading string handling

zombieFox · zombieFox · commit 07d8c864f4d2 · 2020-06-14T16:57:04.000+01:00
diff --git a/src/js/modal.js b/src/js/modal.js
@@ -2,6 +2,8 @@ var modal = (function(){
 
 var _previousModal = null;
 
+ var _maxHeadingLength = 50;
+
 var mod ={};
 
 mod.open = function(){
@@ -108,6 +110,9 @@ var modal = (function(){
 modalControls.appendChild(cancelButton);
 modalControls.appendChild(actionButton);
 if (options.heading != null){
+ if (options.heading.length > _maxHeadingLength){
+ options.heading = options.heading.substring(0, _maxHeadingLength) + "...";
+ };
 var modalHeading = helper.makeNode({
 tag: "h1",
 text: options.heading,

-Original file line number
+Diff line change
 var_previousModal=null;
 +var_maxHeadingLength=50;
++
 varmod={};
 mod.open=function(){
 modalControls.appendChild(cancelButton);
 modalControls.appendChild(actionButton);
 if(options.heading!=null){
 +if(options.heading.length>_maxHeadingLength){
 +options.heading=options.heading.substring(0,_maxHeadingLength)+"...";
 +};
 varmodalHeading=helper.makeNode({
 tag: "h1",
 text: options.heading,