Skip to content

Commit 08e5402

Browse files
committed
[refactor] store accent colour under rgb key in state data
1 parent 8ac1958 commit 08e5402

File tree

11 files changed

+44
-39
lines changed

11 files changed

+44
-39
lines changed

‎package-lock.json‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nighttab",
3-
"version": "4.17.0",
3+
"version": "4.18.0",
44
"description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
55
"main": "index.js",
66
"scripts":{

‎src/index.html‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@
116116
<labelfor="control-theme-color-rgb-quick">Colour</label>
117117
</div>
118118
<divclass="form-input-button input-color-dot input-color-dot-accent">
119-
<inputid="control-theme-accent-current-quick" class="control-theme-accent-current-quick" type="color" value="#000000" tabindex="1">
120-
<labelfor="control-theme-accent-current-quick">Accent</label>
119+
<inputid="control-theme-accent-rgb-quick" class="control-theme-accent-rgb-quick" type="color" value="#000000" tabindex="1">
120+
<labelfor="control-theme-accent-rgb-quick">Accent</label>
121121
</div>
122122
</div>
123123
</div>
@@ -1784,14 +1784,14 @@ <h1 class="menu-item-header-text">Accent</h1>
17841784
</div>
17851785
<divclass="menu-item-form">
17861786
<divclass="form-wrap">
1787-
<labelfor="control-theme-accent-current-picker">Colour</label>
1787+
<labelfor="control-theme-accent-rgb-picker">Colour</label>
17881788
<divclass="form-group form-group-block">
1789-
<inputid="control-theme-accent-current-picker" class="form-group-item-half control-theme-accent-current-picker" type="color" value="#000000" tabindex="1">
1790-
<inputid="control-theme-accent-current-hex" class="form-group-item-half control-theme-accent-current-hex" type="text" placeholder="Hex code" value="#000000" tabindex="1" maxlength="7" autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false">
1789+
<inputid="control-theme-accent-rgb-picker" class="form-group-item-half control-theme-accent-rgb-picker" type="color" value="#000000" tabindex="1">
1790+
<inputid="control-theme-accent-rgb-hex" class="form-group-item-half control-theme-accent-rgb-hex" type="text" placeholder="Hex code" value="#000000" tabindex="1" maxlength="7" autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false">
17911791
</div>
17921792
</div>
17931793
<divclass="form-wrap">
1794-
<buttonclass="control-theme-accent-current-default button" tabindex="-1">Default accent</button>
1794+
<buttonclass="control-theme-accent-rgb-default button" tabindex="-1">Default accent</button>
17951795
</div>
17961796
<divclass="form-helper">
17971797
<pclass="control-theme-style-light-helper form-helper-item">Accent Colour can also be changed from the Header Area.</p>

‎src/js/control.js‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ var control = (function(){
8181
render.class();
8282
}
8383
},{
84-
element: helper.e(".control-theme-accent-current-quick"),
85-
path: "theme.accent.current",
84+
element: helper.e(".control-theme-accent-rgb-quick"),
85+
path: "theme.accent.rgb",
8686
type: "color",
8787
func: function(){
8888
theme.render.accent.color();
@@ -2865,8 +2865,8 @@ var control = (function(){
28652865
render.update();
28662866
}
28672867
},{
2868-
element: helper.e(".control-theme-accent-current-picker"),
2869-
path: "theme.accent.current",
2868+
element: helper.e(".control-theme-accent-rgb-picker"),
2869+
path: "theme.accent.rgb",
28702870
type: "color",
28712871
func: function(){
28722872
theme.render.accent.color();
@@ -2875,8 +2875,8 @@ var control = (function(){
28752875
link.groupAndItems();
28762876
}
28772877
},{
2878-
element: helper.e(".control-theme-accent-current-hex"),
2879-
path: "theme.accent.current",
2878+
element: helper.e(".control-theme-accent-rgb-hex"),
2879+
path: "theme.accent.rgb",
28802880
type: "text",
28812881
valueMod: ["hexTextString"],
28822882
func: function(){
@@ -2886,12 +2886,12 @@ var control = (function(){
28862886
link.groupAndItems();
28872887
}
28882888
},{
2889-
element: helper.e(".control-theme-accent-current-default"),
2889+
element: helper.e(".control-theme-accent-rgb-default"),
28902890
type: "button",
28912891
func: function(){
2892-
mod.setValue("theme.accent.current",helper.getObject({
2892+
mod.setValue("theme.accent.rgb",helper.getObject({
28932893
object: state.get.default(),
2894-
path: "theme.accent.current"
2894+
path: "theme.accent.rgb"
28952895
}));
28962896
theme.render.accent.color();
28972897
theme.render.accent.input.picker();

‎src/js/header.js‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -137,14 +137,14 @@ var header = (function(){
137137
helper.removeClass(helper.getClosest(helper.e(".control-edit"),".form-input-button"),"form-input-button-link");
138138
helper.removeClass(helper.e(".control-add-toggle"),"button-link");
139139
helper.removeClass(helper.getClosest(helper.e(".control-theme-color-rgb-quick"),".form-input-button"),"form-input-button-link");
140-
helper.removeClass(helper.getClosest(helper.e(".control-theme-accent-current-quick"),".form-input-button"),"form-input-button-link");
140+
helper.removeClass(helper.getClosest(helper.e(".control-theme-accent-rgb-quick"),".form-input-button"),"form-input-button-link");
141141
helper.removeClass(helper.e(".control-menu-open"),"button-link");
142142
},
143143
clear: function(){
144144
helper.addClass(helper.getClosest(helper.e(".control-edit"),".form-input-button"),"form-input-button-link");
145145
helper.addClass(helper.e(".control-add-toggle"),"button-link");
146146
helper.addClass(helper.getClosest(helper.e(".control-theme-color-rgb-quick"),".form-input-button"),"form-input-button-link");
147-
helper.addClass(helper.getClosest(helper.e(".control-theme-accent-current-quick"),".form-input-button"),"form-input-button-link");
147+
helper.addClass(helper.getClosest(helper.e(".control-theme-accent-rgb-quick"),".form-input-button"),"form-input-button-link");
148148
helper.addClass(helper.e(".control-menu-open"),"button-link");
149149
}
150150
};
@@ -155,16 +155,16 @@ var header = (function(){
155155
helper.addClass(helper.getClosest(helper.e(".control-theme-color-rgb-quick"),".form-input-button"),"input-color-dot");
156156
helper.addClass(helper.getClosest(helper.e(".control-theme-color-rgb-quick"),".form-input-button"),"input-color-dot-shade");
157157
helper.removeClass(helper.getClosest(helper.e(".control-theme-color-rgb-quick"),".form-input-button"),"form-input-hide");
158-
helper.addClass(helper.getClosest(helper.e(".control-theme-accent-current-quick"),".form-input-button"),"input-color-dot");
159-
helper.addClass(helper.getClosest(helper.e(".control-theme-accent-current-quick"),".form-input-button"),"input-color-dot-accent");
160-
helper.removeClass(helper.getClosest(helper.e(".control-theme-accent-current-quick"),".form-input-button"),"form-input-hide");
158+
helper.addClass(helper.getClosest(helper.e(".control-theme-accent-rgb-quick"),".form-input-button"),"input-color-dot");
159+
helper.addClass(helper.getClosest(helper.e(".control-theme-accent-rgb-quick"),".form-input-button"),"input-color-dot-accent");
160+
helper.removeClass(helper.getClosest(helper.e(".control-theme-accent-rgb-quick"),".form-input-button"),"form-input-hide");
161161
}else{
162162
helper.removeClass(helper.getClosest(helper.e(".control-theme-color-rgb-quick"),".form-input-button"),"input-color-dot");
163163
helper.removeClass(helper.getClosest(helper.e(".control-theme-color-rgb-quick"),".form-input-button"),"input-color-dot-shade");
164164
helper.addClass(helper.getClosest(helper.e(".control-theme-color-rgb-quick"),".form-input-button"),"form-input-hide");
165-
helper.removeClass(helper.getClosest(helper.e(".control-theme-accent-current-quick"),".form-input-button"),"input-color-dot");
166-
helper.removeClass(helper.getClosest(helper.e(".control-theme-accent-current-quick"),".form-input-button"),"input-color-dot-accent");
167-
helper.addClass(helper.getClosest(helper.e(".control-theme-accent-current-quick"),".form-input-button"),"form-input-hide");
165+
helper.removeClass(helper.getClosest(helper.e(".control-theme-accent-rgb-quick"),".form-input-button"),"input-color-dot");
166+
helper.removeClass(helper.getClosest(helper.e(".control-theme-accent-rgb-quick"),".form-input-button"),"input-color-dot-accent");
167+
helper.addClass(helper.getClosest(helper.e(".control-theme-accent-rgb-quick"),".form-input-button"),"form-input-hide");
168168
};
169169
}
170170
};

‎src/js/link.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -552,9 +552,9 @@ var link = (function(){
552552
linkItemOptions.attr[0].value=linkItemOptions.attr[0].value+" link-text-light";
553553
};
554554
}else{
555-
if(invert(state.get.current().theme.accent.current,true)=="#000000"){
555+
if(invert(state.get.current().theme.accent.rgb,true)=="#000000"){
556556
linkItemOptions.attr[0].value=linkItemOptions.attr[0].value+" link-text-dark";
557-
}elseif(invert(state.get.current().theme.accent.current,true)=="#ffffff"){
557+
}elseif(invert(state.get.current().theme.accent.rgb,true)=="#ffffff"){
558558
linkItemOptions.attr[0].value=linkItemOptions.attr[0].value+" link-text-light";
559559
};
560560
};

‎src/js/state.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ var state = (function(){
221221
},
222222
theme: {
223223
accent: {
224-
current: {
224+
rgb: {
225225
r: 0,
226226
g: 80,
227227
b: 255
@@ -369,7 +369,7 @@ var state = (function(){
369369
},
370370
theme: {
371371
accent: {
372-
current: {
372+
rgb: {
373373
r: 0,
374374
g: 80,
375375
b: 255

‎src/js/theme.js‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ var theme = (function(){
4848
});
4949
helper.setObject({
5050
object: state.get.current(),
51-
path: "theme.accent.current",
51+
path: "theme.accent.rgb",
5252
newValue: data.accent
5353
});
5454
helper.setObject({
@@ -137,7 +137,7 @@ var theme = (function(){
137137
varhex=helper.convertColor.rgb.hex(rgb);
138138
helper.setObject({
139139
object: state.get.current(),
140-
path: "theme.accent.current",
140+
path: "theme.accent.rgb",
141141
newValue: {
142142
r: parseInt(rgb.r,10),
143143
g: parseInt(rgb.g,10),
@@ -183,7 +183,7 @@ var theme = (function(){
183183
name: "nightTab (default)",
184184
font: state.get.default().theme.font,
185185
color: state.get.default().theme.color,
186-
accent: state.get.default().theme.accent.current,
186+
accent: state.get.default().theme.accent.rgb,
187187
radius: state.get.default().theme.radius,
188188
shadow: state.get.default().theme.shadow,
189189
style: state.get.default().theme.style,
@@ -1279,18 +1279,18 @@ var theme = (function(){
12791279
render.accent={
12801280
color: function(){
12811281
varhtml=helper.e("html");
1282-
varcolor=state.get.current().theme.accent.current;
1282+
varcolor=state.get.current().theme.accent.rgb;
12831283
html.style.setProperty("--theme-accent",color.r+", "+color.g+", "+color.b);
12841284
},
12851285
input: {
12861286
quick: function(){
1287-
helper.e(".control-theme-accent-current-quick").value=helper.convertColor.rgb.hex(state.get.current().theme.accent.current);
1287+
helper.e(".control-theme-accent-rgb-quick").value=helper.convertColor.rgb.hex(state.get.current().theme.accent.rgb);
12881288
},
12891289
picker: function(){
1290-
helper.e(".control-theme-accent-current-picker").value=helper.convertColor.rgb.hex(state.get.current().theme.accent.current);
1290+
helper.e(".control-theme-accent-rgb-picker").value=helper.convertColor.rgb.hex(state.get.current().theme.accent.rgb);
12911291
},
12921292
hex: function(){
1293-
helper.e(".control-theme-accent-current-hex").value=helper.convertColor.rgb.hex(state.get.current().theme.accent.current);
1293+
helper.e(".control-theme-accent-rgb-hex").value=helper.convertColor.rgb.hex(state.get.current().theme.accent.rgb);
12941294
}
12951295
}
12961296
};
@@ -1699,7 +1699,7 @@ var theme = (function(){
16991699
varsuccessAction=function(){
17001700
stagedThemeCustom.theme.font=state.get.current().theme.font;
17011701
stagedThemeCustom.theme.color=state.get.current().theme.color;
1702-
stagedThemeCustom.theme.accent=state.get.current().theme.accent.current;
1702+
stagedThemeCustom.theme.accent=state.get.current().theme.accent.rgb;
17031703
stagedThemeCustom.theme.radius=state.get.current().theme.radius;
17041704
stagedThemeCustom.theme.shadow=state.get.current().theme.shadow;
17051705
stagedThemeCustom.theme.style=state.get.current().theme.style;

‎src/js/update.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -770,6 +770,11 @@ var update = (function(){
770770
opacity: 0.4
771771
};
772772
returndata;
773+
},
774+
"4.18.0": function(data){
775+
data.state.theme.accent.rgb=data.state.theme.accent.current;
776+
deletedata.state.theme.accent.current;
777+
returndata;
773778
}
774779
};
775780

‎src/js/version.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
varversion=(function(){
22

3-
varcurrent="4.17.0";
3+
varcurrent="4.18.0";
44

55
varname="Naughty Goose";
66

0 commit comments

Comments
(0)