Skip to content

Commit 0ea6147

Browse files
committed
[bug] fix new bookmark modal help text disable state not changing
1 parent 90f103c commit 0ea6147

File tree

5 files changed

+16
-20
lines changed

5 files changed

+16
-20
lines changed

‎package-lock.json‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nightTab",
3-
"version": "5.5.2",
3+
"version": "5.5.3",
44
"description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
55
"main": "index.js",
66
"scripts":{

‎src/js/link.js‎

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1194,9 +1194,21 @@ var link = (function(){
11941194
},false);
11951195
displayLetterRadio.addEventListener("change",function(event){
11961196
stagedLink.link.display=this.value;
1197+
displayLetterInput.removeAttribute("disabled");
1198+
displayIconInput.setAttribute("disabled","");
1199+
helper.addClass(displayIconFormGroupText,"disabled");
1200+
helper.addClass(displayIconHelperItem,"disabled");
1201+
displayIconFormGroupClear.setAttribute("disabled","");
1202+
displayIconFormGroupText.tabIndex=-1;
11971203
},false);
11981204
displayIconRadio.addEventListener("change",function(event){
11991205
stagedLink.link.display=this.value;
1206+
displayLetterInput.setAttribute("disabled","");
1207+
displayIconInput.removeAttribute("disabled");
1208+
helper.removeClass(displayIconFormGroupText,"disabled");
1209+
helper.removeClass(displayIconHelperItem,"disabled");
1210+
displayIconFormGroupClear.removeAttribute("disabled");
1211+
displayIconFormGroupText.tabIndex=1;
12001212
},false);
12011213
displayLetterInput.addEventListener("input",function(event){
12021214
stagedLink.link.letter=this.value;
@@ -1242,22 +1254,6 @@ var link = (function(){
12421254
};
12431255
displayIconInput.value="";
12441256
},false);
1245-
displayLetterRadio.addEventListener("change",function(event){
1246-
displayLetterInput.removeAttribute("disabled");
1247-
displayIconInput.setAttribute("disabled","");
1248-
helper.addClass(displayIconFormGroupText,"disabled");
1249-
helper.addClass(displayIconHelper,"disabled");
1250-
displayIconFormGroupClear.setAttribute("disabled","");
1251-
displayIconFormGroupText.tabIndex=-1;
1252-
},false);
1253-
displayIconRadio.addEventListener("change",function(event){
1254-
displayLetterInput.setAttribute("disabled","");
1255-
displayIconInput.removeAttribute("disabled");
1256-
helper.removeClass(displayIconFormGroupText,"disabled");
1257-
helper.removeClass(displayIconHelper,"disabled");
1258-
displayIconFormGroupClear.removeAttribute("disabled");
1259-
displayIconFormGroupText.tabIndex=1;
1260-
},false);
12611257
autoSuggest.bind.input({
12621258
input: displayIconInput,
12631259
type: "fontawesomeIcon",

‎src/js/version.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
varversion=(function(){
22

3-
varcurrent="5.5.2";
3+
varcurrent="5.5.3";
44

55
varname="Zonked Tarsier";
66

‎src/manifest.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "nightTab",
33
"short_name": "nightTab",
44
"description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
5-
"version": "5.5.2",
5+
"version": "5.5.3",
66
"manifest_version": 2,
77
"chrome_url_overrides":{
88
"newtab": "index.html"

0 commit comments

Comments
(0)