Skip to content

Commit 340fad2

Browse files
committed
[bug] fix search not clearing before link render on load
1 parent 6998637 commit 340fad2

File tree

6 files changed

+18
-11
lines changed

6 files changed

+18
-11
lines changed

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nighttab",
3-
"version": "4.3.0",
3+
"version": "4.4.1",
44
"description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
55
"main": "index.js",
66
"scripts":{

‎src/js/init.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ state.init();
55
bookmarks.init();
66
theme.init();
77
menu.init();
8+
search.init();
89
link.init();
910
control.init();
1011
greeting.init();
@@ -14,7 +15,6 @@ clock.init();
1415
keyboard.init();
1516
layout.init();
1617
background.init();
17-
search.init();
1818
header.init();
1919
modal.init();
2020
shade.init();

‎src/js/link.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1744,10 +1744,10 @@ var link = (function(){
17441744
render.clear.item();
17451745
render.clear.group();
17461746
render.all();
1747-
bind.sort.group();
1748-
bind.sort.item();
17491747
render.group.tabindex();
17501748
render.item.tabindex();
1749+
bind.sort.group();
1750+
bind.sort.item();
17511751
};
17521752

17531753
varinit=function(){

‎src/js/search.js‎

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ var search = (function(){
55
bind.input=function(){
66
varsearchInput=helper.e(".search-input");
77
searchInput.addEventListener("input",function(){
8-
mod.searching.set();
8+
mod.searching.open();
99
render.clear.button();
1010
render.searching();
1111
link.groupAndItems();
@@ -16,7 +16,7 @@ var search = (function(){
1616
varsearchClear=helper.e(".search-clear");
1717
searchClear.addEventListener("click",function(){
1818
render.clear.input();
19-
mod.searching.set();
19+
mod.searching.close();
2020
render.clear.button();
2121
render.searching();
2222
link.groupAndItems();
@@ -26,11 +26,18 @@ var search = (function(){
2626
varmod={};
2727

2828
mod.searching={
29-
set: function(){
29+
open: function(){
3030
helper.setObject({
3131
object: state.get.current(),
3232
path: "search",
33-
newValue: helper.e(".search-input").value!=""
33+
newValue: true
34+
});
35+
},
36+
close: function(){
37+
helper.setObject({
38+
object: state.get.current(),
39+
path: "search",
40+
newValue: false
3441
});
3542
}
3643
};
@@ -123,7 +130,7 @@ var search = (function(){
123130
varinit=function(){
124131
bind.input();
125132
bind.clear();
126-
mod.searching.set();
133+
mod.searching.close();
127134
render.engine();
128135
render.focus();
129136
render.searching();

‎src/js/version.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
varversion=(function(){
22

3-
varcurrent="4.4.0";
3+
varcurrent="4.4.1";
44

55
varname="Enchanting Aardvark";
66

‎src/manifest.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "nightTab",
33
"short_name": "nightTab",
44
"description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
5-
"version": "4.4.0",
5+
"version": "4.4.1",
66
"manifest_version": 2,
77
"chrome_url_overrides":{
88
"newtab": "index.html"

0 commit comments

Comments
(0)