[refactor] add menu open and close button text

zombieFox · zombieFox · commit 614ada97a686 · 2020-07-27T13:53:38.000+01:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
{
 "name": "nightTab",
- "version": "5.71.0",
+ "version": "5.72.0",
 "description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
 "main": "index.js",
 "scripts":{
diff --git a/src/html/menu/close.html b/src/html/menu/close.html
@@ -1,3 +1,6 @@
 <div class="menu-close">
- <button class="menu-close-tab control-menu-close button button-link" tabindex="-1"><span class="icon-close"></span></button>
+ <button class="menu-close-tab control-menu-close button button-link" tabindex="-1">
+ <span class="button-text sr-only">Close settings menu</span>
+ <span class="icon-close"></span>
+ </button>
 </div>
diff --git a/src/js/header.js b/src/js/header.js
@@ -479,13 +479,15 @@ var header = (function(){
 },
 menu: function(){
 var button = helper.node("button|class:control-menu-open header-menu button button-line,tabindex:1");
+ var buttonText = helper.node("span:Open settings menu|class:button-text sr-only");
 var baselineAlignmentCharacter = helper.node("span:-|class:baseline-alignment-icon-character,aria-hidden:true");
 var buttonIcon = helper.node("span|class:icon-settings");
 if (state.get.current().header.menu.style == "clear"){
 helper.addClass(button, "button-link");
 };
 button.appendChild(baselineAlignmentCharacter);
 button.appendChild(buttonIcon);
+ button.appendChild(buttonText);
 return button;
 }
 };
diff --git a/src/js/version.js b/src/js/version.js
@@ -1,6 +1,6 @@
 var version = (function(){
 
- var current = "5.71.0";
+ var current = "5.72.0";
 
 var name = "Jaded Raven";
 
diff --git a/src/manifest.json b/src/manifest.json
@@ -2,7 +2,7 @@
 "name": "nightTab",
 "short_name": "nightTab",
 "description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
- "version": "5.71.0",
+ "version": "5.72.0",
 "manifest_version": 2,
 "chrome_url_overrides":{
 "newtab": "index.html"

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "nightTab",`
`3`		`-"version": "5.71.0",`
	`3`	`+"version": "5.72.0",`
`4`	`4`	`"description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",`
`5`	`5`	`"main": "index.js",`
`6`	`6`	`"scripts":{`
-Original file line number
+Diff line change
@@ @@ -1,3 +1,6 @@ @@
 <divclass="menu-close">
 -<buttonclass="menu-close-tab control-menu-close button button-link" tabindex="-1"><spanclass="icon-close"></span></button>
 +<buttonclass="menu-close-tab control-menu-close button button-link" tabindex="-1">
 +<spanclass="button-text sr-only">Close settings menu</span>
 +<spanclass="icon-close"></span>
 +</button>
 </div>
-Original file line number
+Diff line change
 },
 menu: function(){
 varbutton=helper.node("button|class:control-menu-open header-menu button button-line,tabindex:1");
 +varbuttonText=helper.node("span:Open settings menu|class:button-text sr-only");
 varbaselineAlignmentCharacter=helper.node("span:-|class:baseline-alignment-icon-character,aria-hidden:true");
 varbuttonIcon=helper.node("span|class:icon-settings");
 if(state.get.current().header.menu.style=="clear"){
 helper.addClass(button,"button-link");
 };
 button.appendChild(baselineAlignmentCharacter);
 button.appendChild(buttonIcon);
 +button.appendChild(buttonText);
 returnbutton;
+}
 };
-Original file line number
+Diff line change
@@ @@ -1,6 +1,6 @@ @@
 varversion=(function(){
 -varcurrent="5.71.0";
 +varcurrent="5.72.0";
 varname="Jaded Raven";