[bug] fix color inputs not updating when navigating off page and back

zombieFox · zombieFox · commit 6924ad366137 · 2020-02-19T10:44:57.000Z
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
{
 "name": "nightTab",
- "version": "4.40.1",
+ "version": "4.40.2",
 "description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
 "main": "index.js",
 "scripts":{
diff --git a/src/html/menu/menu-content/theme.html b/src/html/menu/menu-content/theme.html
@@ -262,7 +262,7 @@ <h1 class="menu-item-header-text">Colour</h1>
 <div class="form-wrap">
 <label for="control-theme-color-rgb-color">Primary colour</label>
 <div class="form-group form-group-block">
- <input id="control-theme-color-rgb-color" class="form-group-item-half control-theme-color-rgb-color" type="color" value="#000000" tabindex="1">
+ <input id="control-theme-color-rgb-color" class="form-group-item-half control-theme-color-rgb-color" type="color" value="#000000" tabindex="1" autocomplete="off">
 <input id="control-theme-color-rgb-text" class="form-group-item-half control-theme-color-rgb-text" type="text" placeholder="Hex code" value="#000000" tabindex="1" maxlength="7" autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false">
 <button class="control-theme-color-rgb-default button" tabindex="-1" title="Reset to default"><span class="icon-replay"></span></button>
 </div>
@@ -341,7 +341,7 @@ <h1 class="menu-item-header-text">Accent</h1>
 <div class="form-wrap">
 <label for="control-theme-accent-rgb-color">Colour</label>
 <div class="form-group form-group-block">
- <input id="control-theme-accent-rgb-color" class="form-group-item-half control-theme-accent-rgb-color" type="color" value="#000000" tabindex="1">
+ <input id="control-theme-accent-rgb-color" class="form-group-item-half control-theme-accent-rgb-color" type="color" value="#000000" tabindex="1" autocomplete="off">
 <input id="control-theme-accent-rgb-text" class="form-group-item-half control-theme-accent-rgb-text" type="text" placeholder="Hex code" value="#000000" tabindex="1" maxlength="7" autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false">
 <button class="control-theme-accent-rgb-default button" tabindex="-1" title="Reset to default"><span class="icon-replay"></span></button>
 </div>
diff --git a/src/js/header.js b/src/js/header.js
@@ -400,15 +400,15 @@ var header = (function(){
 var formGroup = helper.node("div|class:header-coloraccent form-group form-group-nested-button");
 
 var colorInputButton = helper.node("div|class:form-input-button");
- var colorInput = helper.node("input|id:control-theme-color-rgb-color-quick,class:control-theme-color-rgb-color-quick,type:color,value:#000000,tabindex:1");
+ var colorInput = helper.node("input|id:control-theme-color-rgb-color-quick,class:control-theme-color-rgb-color-quick,type:color,value:#000000,tabindex:1,autocomplete:off");
 var colorInputLabel = helper.node("label|for:control-theme-color-rgb-color-quick");
 var colorInputLabelText = helper.node("span:Colour");
 colorInputLabel.appendChild(colorInputLabelText);
 colorInputButton.appendChild(colorInput);
 colorInputButton.appendChild(colorInputLabel);
 
 var accentInputButton = helper.node("div|class:form-input-button");
- var accentInput = helper.node("input|id:control-theme-accent-rgb-color-quick,class:control-theme-accent-rgb-color-quick,type:color,value:#000000,tabindex:1");
+ var accentInput = helper.node("input|id:control-theme-accent-rgb-color-quick,class:control-theme-accent-rgb-color-quick,type:color,value:#000000,tabindex:1,autocomplete:off");
 var accentInputLabel = helper.node("label|for:control-theme-accent-rgb-color-quick");
 var accentInputLabelText = helper.node("span:Accent");
 accentInputLabel.appendChild(accentInputLabelText);
diff --git a/src/js/theme.js b/src/js/theme.js
@@ -2006,7 +2006,6 @@ var theme = (function(){
 };
 
 var init = function(){
- accent.random();
 mod.color.generated();
 mod.accent.random();
 mod.custom.close();
diff --git a/src/js/version.js b/src/js/version.js
@@ -1,6 +1,6 @@
 var version = (function(){
 
- var current = "4.40.1";
+ var current = "4.40.2";
 
 var name = "Naughty Goose";
 
diff --git a/src/manifest.json b/src/manifest.json
@@ -2,7 +2,7 @@
 "name": "nightTab",
 "short_name": "nightTab",
 "description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
- "version": "4.40.1",
+ "version": "4.40.2",
 "manifest_version": 2,
 "chrome_url_overrides":{
 "newtab": "index.html"

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "nightTab",`
`3`		`-"version": "4.40.1",`
	`3`	`+"version": "4.40.2",`
`4`	`4`	`"description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",`
`5`	`5`	`"main": "index.js",`
`6`	`6`	`"scripts":{`
-Original file line number
+Diff line change
 <divclass="form-wrap">
 <labelfor="control-theme-color-rgb-color">Primary colour</label>
 <divclass="form-group form-group-block">
 -<inputid="control-theme-color-rgb-color" class="form-group-item-half control-theme-color-rgb-color" type="color" value="#000000" tabindex="1">
 +<inputid="control-theme-color-rgb-color" class="form-group-item-half control-theme-color-rgb-color" type="color" value="#000000" tabindex="1"autocomplete="off">
 <inputid="control-theme-color-rgb-text" class="form-group-item-half control-theme-color-rgb-text" type="text" placeholder="Hex code" value="#000000" tabindex="1" maxlength="7" autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false">
 <buttonclass="control-theme-color-rgb-default button" tabindex="-1" title="Reset to default"><spanclass="icon-replay"></span></button>
 </div>
 <divclass="form-wrap">
 <labelfor="control-theme-accent-rgb-color">Colour</label>
 <divclass="form-group form-group-block">
 -<inputid="control-theme-accent-rgb-color" class="form-group-item-half control-theme-accent-rgb-color" type="color" value="#000000" tabindex="1">
 +<inputid="control-theme-accent-rgb-color" class="form-group-item-half control-theme-accent-rgb-color" type="color" value="#000000" tabindex="1"autocomplete="off">
 <inputid="control-theme-accent-rgb-text" class="form-group-item-half control-theme-accent-rgb-text" type="text" placeholder="Hex code" value="#000000" tabindex="1" maxlength="7" autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false">
 <buttonclass="control-theme-accent-rgb-default button" tabindex="-1" title="Reset to default"><spanclass="icon-replay"></span></button>
 </div>
-Original file line number
+Diff line change
 varformGroup=helper.node("div|class:header-coloraccent form-group form-group-nested-button");
 varcolorInputButton=helper.node("div|class:form-input-button");
 -varcolorInput=helper.node("input|id:control-theme-color-rgb-color-quick,class:control-theme-color-rgb-color-quick,type:color,value:#000000,tabindex:1");
 +varcolorInput=helper.node("input|id:control-theme-color-rgb-color-quick,class:control-theme-color-rgb-color-quick,type:color,value:#000000,tabindex:1,autocomplete:off");
 varcolorInputLabel=helper.node("label|for:control-theme-color-rgb-color-quick");
 varcolorInputLabelText=helper.node("span:Colour");
 colorInputLabel.appendChild(colorInputLabelText);
 colorInputButton.appendChild(colorInput);
 colorInputButton.appendChild(colorInputLabel);
 varaccentInputButton=helper.node("div|class:form-input-button");
 -varaccentInput=helper.node("input|id:control-theme-accent-rgb-color-quick,class:control-theme-accent-rgb-color-quick,type:color,value:#000000,tabindex:1");
 +varaccentInput=helper.node("input|id:control-theme-accent-rgb-color-quick,class:control-theme-accent-rgb-color-quick,type:color,value:#000000,tabindex:1,autocomplete:off");
 varaccentInputLabel=helper.node("label|for:control-theme-accent-rgb-color-quick");
 varaccentInputLabelText=helper.node("span:Accent");
 accentInputLabel.appendChild(accentInputLabelText);
-Original file line number
+Diff line change
@@ @@ -1,6 +1,6 @@ @@
 varversion=(function(){
 -varcurrent="4.40.1";
 +varcurrent="4.40.2";
 varname="Naughty Goose";