Skip to content

Commit 7630486

Browse files
committed
[refactor] improve bookmarks module
1 parent 8648f4d commit 7630486

File tree

3 files changed

+39
-14
lines changed

3 files changed

+39
-14
lines changed

‎src/js/bookmarks.js‎

Lines changed: 37 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
varbookmarks=(function(){
22

3-
varall=[{
3+
varmod={};
4+
5+
mod.all=[{
46
display: "icon",
57
letter: "DEV",
68
icon: {
@@ -173,7 +175,7 @@ var bookmarks = (function(){
173175
timeStamp: 1546453111953
174176
}];
175177

176-
varget=function(data){
178+
mod.get=function(data){
177179
var_singleBookmark=function(){
178180
varfound=false;
179181
for(vari=0;i<all.length;i++){
@@ -190,33 +192,33 @@ var bookmarks = (function(){
190192
};
191193
};
192194

193-
varrestore=function(data){
195+
mod.restore=function(data){
194196
if("bookmarks"indata){
195197
all=data.bookmarks;
196198
};
197199
};
198200

199-
varadd=function(data){
201+
mod.add=function(data){
200202
all.push(data);
201203
};
202204

203-
varedit=function(data){
205+
mod.edit=function(data){
204206
for(vari=0;i<all.length;i++){
205207
if(all[i].timeStamp===data.timeStamp){
206208
all[i]=data;
207209
};
208210
};
209211
};
210212

211-
varremove=function(data){
213+
mod.remove=function(data){
212214
for(vari=0;i<all.length;i++){
213215
if(all[i].timeStamp===data.timeStamp){
214216
all.splice(all.indexOf(all[i]),1);
215217
};
216218
};
217219
};
218220

219-
varsort=function(by){
221+
mod.sort=function(by){
220222
varaction={
221223
name: function(array){
222224
returnhelper.sortObject(array,"name");
@@ -231,27 +233,50 @@ var bookmarks = (function(){
231233
all=action[by](all);
232234
};
233235

234-
varmove=function(origin,destination){
236+
mod.move=function(origin,destination){
235237
all=helper.moveArrayItem(all,origin,destination);
236238
};
237239

240+
varget=function(data){
241+
returnmod.get(data);
242+
};
243+
244+
varadd=function(data){
245+
mod.add(data);
246+
};
247+
248+
varedit=function(data){
249+
mod.edit(data);
250+
};
251+
252+
varsort=function(by){
253+
mod.sort(by);
254+
};
255+
256+
varmove=function(origin,destination){
257+
mod.move(origin,destination);
258+
};
259+
260+
varremove=function(data){
261+
mod.remove(data);
262+
};
263+
238264
varinit=function(){
239265
if(data.load()){
240-
restore(data.load());
266+
mod.restore(data.load());
241267
};
242268
};
243269

244270
// exposed methods
245271
return{
246-
all: all,
247272
init: init,
273+
mod: mod,
248274
get: get,
249275
add: add,
250276
edit: edit,
251277
sort: sort,
252278
move: move,
253-
remove: remove,
254-
restore: restore
279+
remove: remove
255280
};
256281

257282
})();

‎src/js/version.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
varversion=(function(){
22

3-
varcurrent="3.58.0";
3+
varcurrent="3.59.0";
44

55
varcompare=function(a,b){
66
varpa=a.split(".");

‎src/manifest.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "nightTab",
33
"short_name": "nightTab",
44
"description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
5-
"version": "3.58.0",
5+
"version": "3.59.0",
66
"manifest_version": 2,
77
"chrome_url_overrides":{
88
"newtab": "index.html"

0 commit comments

Comments
(0)