Skip to content

Commit 848f236

Browse files
committed
[refactor] improve link add modal
1 parent f473153 commit 848f236

File tree

7 files changed

+33
-12
lines changed

7 files changed

+33
-12
lines changed

‎src/js/keyboard.js‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,6 @@ var keyboard = (function(){
4444
modal.close();
4545
};
4646
link.add();
47-
shade.open({
48-
action: function(){
49-
modal.close();
50-
pagelock.unlock();
51-
}
52-
});
5347
};
5448
};
5549
},false);

‎src/js/link.js‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,23 @@ var link = (function(){
6363
}
6464
};
6565

66+
mod.add={
67+
open: function(){
68+
helper.setObject({
69+
object: state.get(),
70+
path: "link.add",
71+
newValue: true
72+
});
73+
},
74+
close: function(){
75+
helper.setObject({
76+
object: state.get(),
77+
path: "link.add",
78+
newValue: false
79+
});
80+
}
81+
};
82+
6683
varbind={};
6784

6885
bind.sort=function(){
@@ -711,13 +728,15 @@ var link = (function(){
711728
};
712729

713730
varadd=function(){
731+
mod.add.open();
714732
stagedLink.init();
715733
modal.open({
716734
heading: "Add a new bookmark",
717735
successAction: function(){
718736
stagedLink.data.timeStamp=newDate().getTime();
719737
bookmarks.add(JSON.parse(JSON.stringify(stagedLink.data)));
720738
data.save();
739+
mod.add.close();
721740
render.clear();
722741
render.item.all();
723742
render.item.tabindex();
@@ -729,6 +748,7 @@ var link = (function(){
729748
pagelock.unlock();
730749
},
731750
cancelAction: function(){
751+
mod.add.close();
732752
stagedLink.reset();
733753
autoSuggest.destroy();
734754
shade.close();
@@ -740,6 +760,7 @@ var link = (function(){
740760
});
741761
shade.open({
742762
action: function(){
763+
mod.add.close();
743764
modal.close();
744765
pagelock.unlock();
745766
}
@@ -756,6 +777,7 @@ var link = (function(){
756777
};
757778

758779
varinit=function(){
780+
mod.add.close();
759781
render.area.width();
760782
render.item.all();
761783
render.item.tabindex();

‎src/js/menu.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,14 +64,10 @@ var menu = (function(){
6464

6565
render.open=function(){
6666
helper.addClass(helper.e("html"),"is-menu-open");
67-
render.focus();
68-
render.scrollToTop();
69-
render.tabindex.toggle();
7067
};
7168

7269
render.close=function(){
7370
helper.removeClass(helper.e("html"),"is-menu-open");
74-
render.tabindex.toggle();
7571
};
7672

7773
varnav=function(button,area){
@@ -90,6 +86,9 @@ var menu = (function(){
9086
varopen=function(){
9187
mod.open();
9288
render.open();
89+
render.focus();
90+
render.scrollToTop();
91+
render.tabindex.toggle();
9392
shade.open({
9493
action: function(){
9594
mod.close();
@@ -103,6 +102,7 @@ var menu = (function(){
103102
varclose=function(){
104103
mod.close();
105104
render.close();
105+
render.tabindex.toggle();
106106
shade.close();
107107
pagelock.unlock();
108108
};

‎src/js/state.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ var state = (function(){
165165
newTab: false
166166
},
167167
show: true,
168+
add: false,
168169
edit: false,
169170
style: "block"
170171
},

‎src/js/update.js‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -586,6 +586,10 @@ var update = (function(){
586586
data.state.pagelock=false;
587587
data.state.shade=false;
588588
returndata;
589+
},
590+
"3.51.0": function(data){
591+
data.state.link.add=false;
592+
returndata;
589593
}
590594
};
591595

‎src/js/version.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
varversion=(function(){
22

3-
varcurrent="3.50.1";
3+
varcurrent="3.51.0";
44

55
varcompare=function(a,b){
66
varpa=a.split(".");

‎src/manifest.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "nightTab",
33
"short_name": "nightTab",
44
"description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
5-
"version": "3.50.1",
5+
"version": "3.51.0",
66
"manifest_version": 2,
77
"chrome_url_overrides":{
88
"newtab": "index.html"

0 commit comments

Comments
(0)