Skip to content

Commit db89344

Browse files
committed
[refactor] improve page lock render
1 parent c5f5e1b commit db89344

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

‎src/index.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1181,7 +1181,7 @@ <h1 class="menu-item-header-text">nightTab</h1>
11811181
<scriptsrc="js/background.js"></script>
11821182
<scriptsrc="js/layout.js"></script>
11831183
<scriptsrc="js/auto-suggest.js"></script>
1184-
<scriptsrc="js/page.js"></script>
1184+
<scriptsrc="js/pagelock.js"></script>
11851185
<scriptsrc="js/edge.js"></script>
11861186
<scriptsrc="js/init.js"></script>
11871187

‎src/js/control.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ var control = (function(){
55
type: "button",
66
func: function(){
77
menu.toggle();
8-
page.update();
8+
pagelock.render.toggle();
99
}
1010
},{
1111
element: helper.e(".control-link-add"),

‎src/js/menu.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ var menu = (function(){
1111
menuClose.addEventListener("click",function(){
1212
close();
1313
shade.destroy();
14-
page.update();
14+
pagelock.render.toggle();
1515
},false);
1616
};
1717

@@ -88,7 +88,7 @@ var menu = (function(){
8888
shade.render({
8989
action: function(){
9090
close();
91-
page.update();
91+
pagelock.render.toggle();
9292
}
9393
});
9494
}else{

‎src/js/modal.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,15 +105,15 @@ var modal = (function(){
105105
};
106106
this.destroy();
107107
shade.destroy();
108-
page.update();
108+
pagelock.render.toggle();
109109
}.bind(modal),false);
110110
cancelButton.addEventListener("click",function(event){
111111
if(options.cancelAction){
112112
options.cancelAction();
113113
};
114114
this.destroy();
115115
shade.destroy();
116-
page.update();
116+
pagelock.render.toggle();
117117
}.bind(modal),false);
118118
previousModal=modal;
119119
shade.render({
@@ -122,7 +122,7 @@ var modal = (function(){
122122
options.cancelAction();
123123
};
124124
modal.destroy();
125-
page.update();
125+
pagelock.render.toggle();
126126
},
127127
includeHeader: true
128128
});
@@ -136,7 +136,7 @@ var modal = (function(){
136136
destroy();
137137
};
138138
_makeModal();
139-
page.update();
139+
pagelock.render.toggle();
140140
};
141141

142142
// exposed methods
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
varpage=(function(){
1+
varpagelock=(function(){
22

3-
varupdate=function(){
3+
varrender={};
4+
5+
render.toggle=function(){
46
varbody=helper.e("body");
57
varmenu=state.get().menu;
68
varmodal=state.get().modal;
@@ -12,21 +14,19 @@ var page = (function(){
1214
};
1315
};
1416

15-
varlock=function(){
17+
render.lock=function(){
1618
varbody=helper.e("body");
1719
helper.addClass(body,"scroll-disabled");
1820
};
1921

20-
varunlock=function(){
22+
render.unlock=function(){
2123
varbody=helper.e("body");
2224
helper.removeClass(body,"scroll-disabled");
2325
};
2426

2527
// exposed methods
2628
return{
27-
lock: lock,
28-
unlock: unlock,
29-
update: update
29+
render: render
3030
};
3131

3232
})();

0 commit comments

Comments
(0)