[refactor] improve theme color

zombieFox · zombieFox · commit dede8e43b3f7 · 2020-01-05T20:58:31.000-07:00
diff --git a/src/js/theme.js b/src/js/theme.js
@@ -1041,7 +1041,6 @@ var theme = (function(){
 render.color ={
 shade: function(){
 var shadeSteps = 10;
- var saturationShift = 0;
 var lightShift = 4;
 var html = helper.e("html");
 var hsl = helper.convertColor.rgb.hsl(state.get.current().theme.color.rgb);
@@ -1057,23 +1056,21 @@ var theme = (function(){
 };
 if (index < 10){
 index = "0" + index;
- } else{
- index = index;
 };
 html.style.setProperty(name + index, rgb.r + ", " + rgb.g + ", " + rgb.b);
 };
 for (var i = 1; i <= shadeSteps; i++){
 var rgb = helper.convertColor.hsl.rgb({
 h: hsl.h,
- s: hsl.s - (saturationShift * i),
+ s: hsl.s,
 l: hsl.l - (lightShift * i)
 });
 renderShade("--theme-shade-neg-", i, rgb);
 };
 for (var i = 1; i <= shadeSteps; i++){
 var rgb = helper.convertColor.hsl.rgb({
 h: hsl.h,
- s: hsl.s + (saturationShift * i),
+ s: hsl.s,
 l: hsl.l + (lightShift * i)
 });
 renderShade("--theme-shade-pos-", i, rgb);

-Original file line number
+Diff line change
 render.color={
 shade: function(){
 varshadeSteps=10;
 -varsaturationShift=0;
 varlightShift=4;
 varhtml=helper.e("html");
 varhsl=helper.convertColor.rgb.hsl(state.get.current().theme.color.rgb);
 };
 if(index<10){
 index="0"+index;
 -}else{
 -index=index;
 };
 html.style.setProperty(name+index,rgb.r+", "+rgb.g+", "+rgb.b);
 };
 for(vari=1;i<=shadeSteps;i++){
 varrgb=helper.convertColor.hsl.rgb({
 h: hsl.h,
 -s: hsl.s-(saturationShift*i),
 +s: hsl.s,
 l: hsl.l-(lightShift*i)
 });
 renderShade("--theme-shade-neg-",i,rgb);
 };
 for(vari=1;i<=shadeSteps;i++){
 varrgb=helper.convertColor.hsl.rgb({
 h: hsl.h,
 -s: hsl.s+(saturationShift*i),
 +s: hsl.s,
 l: hsl.l+(lightShift*i)
 });
 renderShade("--theme-shade-pos-",i,rgb);