Skip to content

Commit e87a004

Browse files
committed
[refactor] improve bookmark edit function
1 parent f96f355 commit e87a004

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

‎js/bookmarks.js‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,10 +188,17 @@ var bookmarks = (function(){
188188
all.push(newBookmark);
189189
};
190190

191-
varedit=function(object,timeStamp){
191+
varedit=function(override){
192+
varoptions={
193+
bookmarkData: null,
194+
timeStamp: null
195+
};
196+
if(override){
197+
options=helper.applyOptions(options,override);
198+
};
192199
for(vari=0;i<all.length;i++){
193-
if(all[i].timeStamp===timeStamp){
194-
all[i]=object;
200+
if(all[i].timeStamp===options.timeStamp){
201+
all[i]=options.bookmarkData;
195202
};
196203
};
197204
};

‎js/link.js‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,10 @@ var link = (function(){
9090
options.bookmarkData.letter=options.form.querySelector(".link-form-input-letter").value;
9191
options.bookmarkData.name=options.form.querySelector(".link-form-input-name").value;
9292
options.bookmarkData.url=options.form.querySelector(".link-form-input-url").value;
93-
bookmarks.edit(options.bookmarkData,options.bookmarkData.timeStamp);
93+
bookmarks.edit({
94+
bookmarkData: options.bookmarkData,
95+
timeStamp: options.bookmarkData.timeStamp
96+
});
9497
}
9598
};
9699
action[options.action]();

0 commit comments

Comments
(0)