Best effort failure excluded

Author: som-snytt

compiler/test/dotc/neg-best-effort-unpickling.excludelist

@@ -24,3 +24,6 @@ context-function-syntax.scala
 
 # Failure to disambiguate overloaded reference
 i23402b.scala
+
+# owner of anon, where package object has funky name
+i20511-1.scala

compiler/test/dotty/tools/dotc/BestEffortOptionsTests.scala

@@ -2,44 +2,42 @@ package dotty
 packagetools
 packagedotc
 
-importscala.concurrent.duration._
-importdotty.tools.vulpix._
-importorg.junit.{Test, AfterClass }
+importdotty.tools.vulpix.*
 importreporting.TestReporter
-importjava.io.{File=>JFile}
 
+importscala.concurrent.duration.*
 importscala.language.unsafeNulls
 
+importjava.io.{File=>JFile}
+importorg.junit.{AfterClass, Test}
+
 classBestEffortOptionsTests{
-importParallelTesting._
-importvulpix.TestConfiguration._
-importBestEffortOptionsTests._
-importCompilationTest.aggregateTests
+importParallelTesting.*
+importvulpix.TestConfiguration.*
+importBestEffortOptionsTests.*
 
 // Since TASTy and beTASTy files are read in a lazy manner (only when referenced by the source .scala file)
 // we test by using the "-from-tasty" option. This guarantees that the tasty files will be read
 // (and that the Best Effort TASTy reader will be tested), but we unfortunately skip the useful
 // interactions a tree derived from beTASTy could have with other frontend phases.
-@TestdefnegTestFromBestEffortTasty:Unit={
+@TestdefnegTestFromBestEffortTasty:Unit=
 // Can be reproduced with
 // > sbt
-// > scalac --Ybest-effort -Xsemanticdb <source>
-// > scalac --from-tasty -Ywith-best-effort-tasty META_INF/best-effort/<betasty>
+// > scalac -Ybest-effort -Xsemanticdb <source>
+// > scalac -from-tasty -Ywith-best-effort-tasty META_INF/best-effort/<betasty>
 
-implicitvaltestGroup:TestGroup=TestGroup("negTestFromBestEffortTasty")
+givenTestGroup=TestGroup("negTestFromBestEffortTasty")
  compileBestEffortTastyInDir(s"tests${JFile.separator}neg", bestEffortBaselineOptions,
  picklingFilter =FileFilter.exclude(TestSources.negBestEffortPicklingExcludelisted),
  unpicklingFilter =FileFilter.exclude(TestSources.negBestEffortUnpicklingExcludelisted)
  ).checkNoCrash()
- }
 
 // Tests an actual use case of this compilation mode, where symbol definitions of the downstream
 // projects depend on the best effort tasty files generated with the Best Effort dir option
-@TestdefbestEffortIntergrationTest:Unit={
-implicitvaltestGroup:TestGroup=TestGroup("bestEffortIntegrationTests")
+@TestdefbestEffortIntegrationTest:Unit=
+givenTestGroup=TestGroup("bestEffortIntegrationTests")
  compileBestEffortIntegration(s"tests${JFile.separator}best-effort", bestEffortBaselineOptions)
  .noCrashWithCompilingDependencies()
- }
 }
 
 objectBestEffortOptionsTestsextendsParallelTesting{