fix(jruby): Node#attribute in HTML documents

and anything that depends on that, like NodeSet#attr. Fixes#3487

Author: flavorjones

ext/java/nokogiri/XmlNode.java

@@ -652,7 +652,7 @@ public class XmlNode extends RubyObject
 Nodeattribute = attributes.item(j);
 StringlocalName = attribute.getLocalName();
 if (localName == null){
-continue;
+localName = attribute.getNodeName();
  }
 if (localName.equals(name)){
 returngetCachedNodeOrCreate(context.runtime, attribute);

test/html4/test_node.rb

@@ -23,7 +23,15 @@ def test_to_a
 
 deftest_attr
 node=@html.at("div.baz")
-assert_equal(node["class"],node.attr("class"))
+assert_equal("baz",node["class"])
+assert_equal("baz",node.attr("class"))
+end
+
+deftest_attribute
+# https://github.com/sparklemotion/nokogiri/issues/3487
+node=@html.at("div.baz")
+refute_nil(node.attribute("class"))
+assert_equal("baz",node.attribute("class").value)
 end
 
 deftest_get_attribute

test/xml/test_node_set.rb

@@ -129,6 +129,23 @@ class TestNodeSet < Nokogiri::TestCase
 end
 end
 
+it"#attr on XML gets attribute from first node"do
+doc=Nokogiri::XML("<root><child name='ruby' /><child name='python' /></root>")
+children=doc.css("child")
+
+refute_nil(children.attr("name"))
+assert_equal(children.first.attribute("name"),children.attr("name"))
+end
+
+it"#attr on HTML gets attribute from first node"do
+# https://github.com/sparklemotion/nokogiri/issues/3487
+doc=Nokogiri::HTML("<root><child name='ruby' /><child name='python' /></root>")
+children=doc.css("child")
+
+refute_nil(children.attr("name"))
+assert_equal(children.first.attribute("name"),children.attr("name"))
+end
+
 it"#attribute with no args gets attribute from first node"do
 list.first["foo"]="bar"
 assert_equal(list.first.attribute("foo"),list.attribute("foo"))