Skip to content

Commit cddcd60

Browse files
committed
- one more workaround for _adjustContentOffsetIfNecessary
- fixed documentation issues
1 parent d2ea402 commit cddcd60

File tree

6 files changed

+12
-7
lines changed

6 files changed

+12
-7
lines changed

‎Demo/SCStackViewController.xcodeproj/project.pbxproj‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -498,6 +498,7 @@
498498
CLANG_CXX_LIBRARY = "libc++"
499499
CLANG_ENABLE_OBJC_ARC = YES;
500500
CLANG_WARN_CONSTANT_CONVERSION = YES;
501+
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
501502
CLANG_WARN_EMPTY_BODY = YES;
502503
CLANG_WARN_ENUM_CONVERSION = YES;
503504
CLANG_WARN_INT_CONVERSION = YES;
@@ -531,6 +532,7 @@
531532
CLANG_CXX_LIBRARY = "libc++"
532533
CLANG_ENABLE_OBJC_ARC = YES;
533534
CLANG_WARN_CONSTANT_CONVERSION = YES;
535+
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
534536
CLANG_WARN_EMPTY_BODY = YES;
535537
CLANG_WARN_ENUM_CONVERSION = YES;
536538
CLANG_WARN_INT_CONVERSION = YES;

‎Demo/SCStackViewController/TitleBarDemo/SCTitleBarCollectionViewCell.m‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ @implementation SCTitleBarCollectionViewCell
1818

1919
- (void)awakeFromNib
2020
{
21+
[superawakeFromNib];
22+
2123
[self.imageView.layer setCornerRadius:10.0f];
2224
}
2325

‎SCStackViewController.podspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.newdo |s|
22
s.name='SCStackViewController'
3-
s.version='3.3.3'
3+
s.version='3.3.4'
44
s.platform=:ios
55
s.ios.deployment_target='5.0'
66

‎SCStackViewController/Layouters/SCStackLayouterProtocol.h‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
* @param viewController The view controller for which to calculate the frame
2222
* @param index The index of the view controller in the Stack's children array
2323
* @param position The position in the stack
24-
* @param viewController The full children array for the given position
24+
* @param viewControllers The full children array for the given position
2525
* @param stackViewController The calling StackViewController
2626
*
2727
* @return The frame for the viewController's view
@@ -92,9 +92,8 @@
9292
/** Returns the root view controller sublayer transformation that should be used
9393
* for the currnet stack offset
9494
*
95-
* @param viewController The view controller for which to calculate the frame
96-
* @param index The index of the view controller in the Stack's children array
97-
* @param position The position in the stack
95+
* @param rootViewController the stack's root view controller
96+
* @param contentOffset current offset in the Stack's scrollView
9897
* @param stackViewController The calling StackViewController
9998
*
10099
* @return The sublayer transformation to be applied

‎SCStackViewController/SCStackViewController.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ typedef NS_OPTIONS(NSUInteger, SCStackViewControllerNavigationContraintType){
280280

281281
/**
282282
* @return BOOL value representing the visibility of the passed view controller
283-
* @param @param viewController The view controller for which to check the
283+
* @param viewController The view controller for which to check the
284284
* visibility
285285
*
286286
* A view controller is visible when any part of it is visible (within the
@@ -291,7 +291,7 @@ typedef NS_OPTIONS(NSUInteger, SCStackViewControllerNavigationContraintType){
291291

292292
/**
293293
* @return Float value representing the visible percentage
294-
* @param @param viewController The view controller for which to fetch the
294+
* @param viewController The view controller for which to fetch the
295295
* visible percentage
296296
*
297297
* A view controller is visible when any part of it is visible (within the

‎SCStackViewController/SCStackViewController.m‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@ - (void)setup
9494
[selfsetPagingEnabled:YES];
9595
[self.scrollView setShowsHorizontalScrollIndicator:NO];
9696
[self.scrollView setShowsVerticalScrollIndicator:NO];
97+
98+
[self.scrollView setContentOffset:CGPointZero]; // Overrides whatever _adjustContentOffsetIfNecessary might do
9799
}
98100

99101
#pragma mark - Public Methods

0 commit comments

Comments
(0)