Skip to content

Conversation

@Tranquility2
Copy link
Contributor

This will address the Security issue reported on #786
As recommended, tj-actions/changed-files was replace replaced with path-filter

@Tranquility2
Copy link
ContributorAuthor

Tranquility2 commented Mar 15, 2025

Note to reviewer, I keep the testing so we can see it works the same.
Testing locally is limited (I used act)
the final result looks like
[modules/track-modules] ⚙ ::set-output:: computed_modules=["aws","generic"]
which looks compatibale with what we had on (for example) https://github.com/testcontainers/testcontainers-python/actions/runs/13502155079/job/37723003600?pr=778
image

computed_modules=["scylla"]

dir_names: true
dir_names_exclude_current_dir: true
json: true
base: ${{github.ref }}
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this was needed locally, we can try without on a later stage

@Tranquility2Tranquility2 changed the title Track modules updateUpdate track-modules job Mar 15, 2025
@Tranquility2Tranquility2 changed the title Update track-modules job fix(security): Update track-modules job Mar 15, 2025
- name: Get changed files
id: changed-files
uses: tj-actions/changed-files@v42
uses: dorny/paths-filter@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Can we use the pinned version of v3 (passing the commit hash)?

Copy link
Member

@mdelapenyamdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW the GH action was restored removing the offending commit. In the case we want to keep it, I'd encourage using a pinned version of the action. And if possible, also pin any other GH action

@codecov
Copy link

codecovbot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a0785d7). Learn more about missing BASE report.

Additional details and impacted files
@@ Coverage Diff @@## main #787 +/- ## ======================================= Coverage ? 84.73% ======================================= Files ? 12 Lines ? 668 Branches ? 105 ======================================= Hits ? 566 Misses ? 79 Partials ? 23 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@alexanderankinalexanderankin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@alexanderankinalexanderankin merged commit f979525 into testcontainers:mainMar 17, 2025
19 checks passed
alexanderankin pushed a commit that referenced this pull request Apr 2, 2025
🤖 I have created a release *beep* *boop* --- ## [4.10.0](testcontainers-v4.9.2...testcontainers-v4.10.0) (2025-04-02) ### Features * Add SocatContainer ([#795](#795)) ([2f9139c](2f9139c)) ### Bug Fixes * **ollama:** make device request a list ([#799](#799)) ([9497a45](9497a45)) * **security:** Update track-modules job ([#787](#787)) ([f979525](f979525)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Tranquility2@mdelapenya@alexanderankin