feat: DockerContainer initializer to accept its private members as kwargs#809
+65 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
alexanderankin changed the title 
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #809 +/- ## ======================================= Coverage ? 85.46% ======================================= Files ? 12 Lines ? 688 Branches ? 110 ======================================= Hits ? 588 Misses ? 75 Partials ? 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
alexanderankin commented May 18, 2025
will rebase tomorrow and then probably will look it over once more and merge |
alexanderankinforce-pushed the container_initializer_accept_more_kwargs branch from 7160514 to 711ec78Compare
alexanderankin approved these changes May 18, 2025
alexanderankin merged commit e7feb53 into testcontainers:main 10 checks passed
Uh oh!
There was an error while loading. Please reload this page.
alexanderankin pushed a commit that referenced this pull request Jun 16, 2025
🤖 I have created a release *beep* *boop* --- ## [4.11.0](testcontainers-v4.10.0...testcontainers-v4.11.0) (2025-06-15) ### Features * **core:** Protocol support for container port bind and expose ([#690](#690)) ([a0d4317](a0d4317)) * DockerContainer initializer to accept its private members as kwargs ([#809](#809)) ([e7feb53](e7feb53)) ### Bug Fixes * **compose:** use provided docker command instead of default ([#785](#785)) ([0ae704a](0ae704a)) * **core:** Add kwargs to image build ([#708](#708)) ([cc02f94](cc02f94)) * **core:** change with_command type to include list of strings ([#789](#789)) ([f7c29cb](f7c29cb)) * **core:** Determine docker socket for rootless docker ([#779](#779)) ([6817582](6817582)) * **core:** Typing in docker_client ([#702](#702)) ([e8bf224](e8bf224)) * **core:** Typing in generic + network ([#700](#700)) ([2061912](2061912)) * **core:** Typing in version ([#701](#701)) ([9dc2a02](9dc2a02)) * **core:** wait in test core registry ([#812](#812)) ([b574c0e](b574c0e)) * **modules:** fix cosmosdb failure ([#827](#827)) ([dafcbed](dafcbed)) * **modules:** update chroma version ([#826](#826)) ([b7d41dd](b7d41dd)) * **rabbitmq:** correct pika pypi reference ([#817](#817)) ([e90d308](e90d308)) * **registry:** module typed ([#811](#811)) ([6b11268](6b11268)) * use connection mode override function in config ([#775](#775)) ([ab2a1ab](ab2a1ab)), closes [#774](#774) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
terry-docker added a commit to terry-docker/testcontainers-python that referenced this pull request Jun 17, 2025
…args (testcontainers#809) Re submitting what is the end result of the iterations in testcontainers#238 submitted originally by @vikhal. Simply enabling the initializer of `DockerContainer` to accept its private members as kwargs. --------- Co-authored-by: David Ankin <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re submitting what is the end result of the iterations in #238 submitted originally by @vikhal.
Simply enabling the initializer of
DockerContainerto accept its private members as kwargs.