Fix flake8 check and related warnings

Author: gyermolenko

.travis.yml

@@ -20,7 +20,7 @@ script:
  - pytest -s -vv --cov=. --log-level=INFO tests/
 # Actually run all the scripts, contributing to coverage
  - PYTHONPATH=. ./run_all.sh
- - flake8 *py
+ - flake8 patterns/
 
 after_success:
  - codecov

append_output.sh

@@ -16,4 +16,4 @@ echo "$src" > $1
 echo -e "\n">>$1
 echo"$output_marker">>$1
 echo"$output">>$1
-echo'"""'>>$1
+echo'""" # noqa'>>$1

patterns/behavioral/command.py

@@ -6,7 +6,8 @@
 Encapsulates all information needed to perform an action or trigger an event.
 
 *Examples in Python ecosystem:
-Django HttpRequest (without `execute` method): https://docs.djangoproject.com/en/2.1/ref/request-response/#httprequest-objects
+Django HttpRequest (without `execute` method):
+ https://docs.djangoproject.com/en/2.1/ref/request-response/#httprequest-objects
 """
 
 from __future__ importprint_function

patterns/behavioral/iterator.py

@@ -29,13 +29,9 @@ def main():
 fornumberincount_to_two():
 print(number, end=' ')
 
-print()
-
-print('Counting to five...')
+print('\nCounting to five...')
 fornumberincount_to_five():
 print(number, end=' ')
-
-print()
 
 
 if__name__=="__main__":
@@ -47,4 +43,4 @@ def main():
 one two 
 Counting to five...
 one two three four five 
-"""
+"""# noqa

patterns/behavioral/mediator.py.bkp

@@ -0,0 +1,165 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+
+"""
+http://web.archive.org/web/20120309135549/http://dpip.testingperspective.com/?p=28
+
+*TL;DR80
+Encapsulates how a set of objects interact.
+"""
+
+importrandom
+importtime
+
+
+classTC:
+"""TestCategory
+ responsible for running the tests with the help of setup(), execute() and tearDown() methods
+ """
+
+def__init__(self):
+self._tm=None
+self._bProblem=0
+
+defsetup(self):
+print("Setting up the Test")
+time.sleep(0.1)
+self._tm.prepareReporting()
+
+defexecute(self):
+ifnotself._bProblem:
+print("Executing the test")
+time.sleep(0.1)
+else:
+print("Problem in setup. Test not executed.")
+
+deftearDown(self):
+ifnotself._bProblem:
+print("Tearing down")
+time.sleep(0.1)
+self._tm.publishReport()
+else:
+print("Test not executed. No tear down required.")
+
+defsetTM(self, tm):
+self._tm=tm
+
+defsetProblem(self, value):
+self._bProblem=value
+
+
+classReporter:
+"""
+ - calls its prepare() method while TestCategory starts getting executed
+ - calls its report() method when TestCategory finishes its execution.
+ """
+def__init__(self):
+self._tm=None
+
+defprepare(self):
+print("Reporter Class is preparing to report the results")
+time.sleep(0.1)
+
+defreport(self):
+print("Reporting the results of Test")
+time.sleep(0.1)
+
+defsetTM(self, tm):
+self._tm=tm
+
+
+classDB:
+"""
+ stores the execution status of the test category by first
+ calling the insert() method while the test category is in setup(),
+ and then calls the update() method once the test category has finished execution.
+ In this way, at any given point of time, the test execution status is available for framework user to query from the database
+ """
+def__init__(self):
+self._tm=None
+
+definsert(self):
+print("Inserting the execution begin status in the Database")
+time.sleep(0.1)
+# Following code is to simulate a communication from DB to TC
+ifrandom.randrange(1, 4) ==3:
+return-1
+
+defupdate(self):
+print("Updating the test results in Database")
+time.sleep(0.1)
+
+defsetTM(self, tm):
+self._tm=tm
+
+
+classTestManager:
+"""
+ Mediator between Class TC, Class Reporter and Class DB, the Colleagues in the system
+ coordinates for
+ test category execution (Class TC)
+ and fetching the reports (Class Reporter)
+ and getting the test execution status in database (Class DB) with the help of prepareReporting() and publishReport() methods
+ """
+def__init__(self):
+self._reporter=None
+self._db=None
+self._tc=None
+
+defprepareReporting(self):
+rvalue=self._db.insert()
+ifrvalue==-1:
+self._tc.setProblem(1)
+self._reporter.prepare()
+
+defsetReporter(self, reporter):
+self._reporter=reporter
+
+defsetDB(self, db):
+self._db=db
+
+defpublishReport(self):
+self._db.update()
+self._reporter.report()
+
+defsetTC(self, tc):
+self._tc=tc
+
+
+if__name__=='__main__':
+reporter=Reporter()
+db=DB()
+tm=TestManager()
+tm.setReporter(reporter)
+tm.setDB(db)
+reporter.setTM(tm)
+db.setTM(tm)
+# For simplification we are looping on the same test.
+# Practically, it could be about various unique test classes and their
+# objects
+foriinrange(3):
+tc=TC()
+tc.setTM(tm)
+tm.setTC(tc)
+tc.setup()
+tc.execute()
+tc.tearDown()
+
+### OUTPUT ###
+# Setting up the Test
+# Inserting the execution begin status in the Database
+# Executing the test
+# Tearing down
+# Updating the test results in Database
+# Reporting the results of Test
+# Setting up the Test
+# Inserting the execution begin status in the Database
+# Reporter Class is preparing to report the results
+# Problem in setup. Test not executed.
+# Test not executed. No tear down required.
+# Setting up the Test
+# Inserting the execution begin status in the Database
+# Executing the test
+# Tearing down
+# Updating the test results in Database
+# Reporting the results of Test

patterns/behavioral/memento.py

@@ -98,25 +98,26 @@ def main():
 print(num_obj)
 num_obj.value+='x'# will fail
 print(num_obj)
-exceptExceptionase:
+exceptException:
 a_transaction.rollback()
 print('-- rolled back')
 print(num_obj)
 
 print('-- now doing stuff ...')
 try:
 num_obj.do_stuff()
-exceptExceptionase:
+exceptException:
 print('-> doing stuff failed!')
 importsys
 importtraceback
 
 traceback.print_exc(file=sys.stdout)
 print(num_obj)
 
+
 if__name__=='__main__':
 main()
-
+
 
 OUTPUT="""
 <NumObj: -1>

patterns/behavioral/specification.py

@@ -102,7 +102,7 @@ def main():
 print(root_specification.is_satisfied_by(ivan))
 print(root_specification.is_satisfied_by(vasiliy))
 
-
+
 if__name__=='__main__':
 main()
 

patterns/behavioral/state.py

@@ -76,7 +76,7 @@ def main():
 foractioninactions:
 action()
 
-
+
 if__name__=='__main__':
 main()
 

patterns/behavioral/template.py

@@ -5,7 +5,7 @@
 An example of the Template pattern in Python
 
 *TL;DR80
-Defines the skeleton of a base algorithm, deferring definition of exact
+Defines the skeleton of a base algorithm, deferring definition of exact
 steps to subclasses.
 
 *Examples in Python ecosystem:

patterns/fundamental/delegation_pattern.py

@@ -32,7 +32,7 @@ def __init__(self, delegate):
 
 def__getattr__(self, name):
 attr=getattr(self.delegate, name)
-
+
 ifnotcallable(attr):
 returnattr