Skip to content

Commit b7c68b0

Browse files
committed
Minor typo fixing / formatting change / rephrasing.
1 parent 7c36c9e commit b7c68b0

File tree

1 file changed

+15
-14
lines changed

1 file changed

+15
-14
lines changed

‎rev_news/drafts/edition-44.md‎

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ navbar: false
1111

1212
Welcome to the 44th edition of [Git Rev News](https://git.github.io/rev_news/rev_news/),
1313
a digest of all things Git. For our goals, the archives, the way we work, and how to contribute or to
14-
subscribe, see [the Git Rev News page](https://git.github.io/rev_news/rev_news/) on [git.github.io](http://git.github.io).
14+
subscribe, see [the Git Rev News page](https://git.github.io/rev_news/rev_news/) on [git.github.io](https://git.github.io).
1515

1616
This edition covers what happened during the month of September 2018.
1717

@@ -26,7 +26,7 @@ This edition covers what happened during the month of September 2018.
2626

2727
*[Add an EditorConfig file](https://public-inbox.org/git/[email protected]/)
2828

29-
Brian Carlson sent a patch that adds an ".editorconfig" file to the
29+
Brian Carlson sent a patch that adds a `.editorconfig` file to the
3030
Git codebase.
3131

3232
The [EditorConfig web site](https://editorconfig.org/) explains the
@@ -41,34 +41,35 @@ codebase without having to read the [CodingGuidelines document](https://github.c
4141

4242
Taylor Blau, who has been using Vim with the editorconfig-vim plugin
4343
for years, supported the patch and the choice of settings that Brian
44-
had written in the ".editorconfig" file. He suggested adding a
44+
had written in the `.editorconfig` file. He suggested adding a
4545
guideline to enforce at most 72 characters per line in commit
4646
messages.
4747

4848
Junio Hamano, the Git maintainer, also replied to Brian wondering how
49-
to keep the content of the file in sync with the [".clang-format" file](https://github.com/git/git/blob/master/.clang-format)
49+
to keep the content of the file in sync with the [`.clang-format` file](https://github.com/git/git/blob/master/.clang-format)
5050
that is already part of the project and can be used through the
5151
`style` Makefile target.
5252

5353
Brian replied to Junio that `make style` is not run automatically and
5454
only formats C code, not Perl, Python, shell code and commit
5555
messages. Brian also said that he had trouble running `make style` as
56-
it invokes clang-format as a git subcommand.
56+
it invokes `clang-format` as a Git subcommand.
5757

58-
Junio replied that he would have liked if there was a tool that could
59-
"generate clang-format configuration from the section for C language
60-
in any EditorConfig file", but in case there isn't he is ok with
61-
maintaining both config files.
58+
Junio replied that in an ideal dream-world, an EditorConfig driven
59+
tool solution to "generate clang-format configuration from the section
60+
for C language in any EditorConfig file" already existed,
61+
but otherwise he would be "perfectly OK if the plan is to manually
62+
keep them (loosely) in sync".
6263

6364
Eric Sunshine then pointed Brian to [git-clang-format](https://llvm.org/svn/llvm-project/cfe/trunk/tools/clang-format/git-clang-format)
64-
which integrates clang-format with Git, so that clang-format can be
65+
which integrates `clang-format` with Git, so that clang-format can be
6566
run on the changes in current files or a specific commit.
6667

6768
This prompted Peff and Brian to discuss possible improvements in
68-
Debian or Git that would make git-clang-format work better.
69+
Debian or Git that would make `git-clang-format` work better.
6970

7071
Responding to Junio, Brian suggested adding a script to check that
71-
".editorconfig" and ".clang-format" were kept in sync, but Junio
72+
`.editorconfig` and `.clang-format` were kept in sync, but Junio
7273
replied that adding a comment in both files saying that they should be
7374
kept in sync would be enough.
7475

@@ -77,8 +78,8 @@ of his patch which enforces at most 72 characters per line in commit
7778
messages along with another patch that adds the comments that Junio
7879
suggested.
7980

80-
Ævar Arnfjörð Bjarmason suggested an improvement to also catch perl
81-
files with the ".pl" and ".pm" file extensions. Brian
81+
Ævar Arnfjörð Bjarmason suggested an improvement to also catch Perl
82+
files with the `.pl` and `.pm` file extensions. Brian
8283
implemented this in a [third version](https://public-inbox.org/git/[email protected]/)
8384
of his patches.
8485

0 commit comments

Comments
(0)