Performance fix

- Usage of resolved loopback IP address instead of 'localhost' Addresses aspnet#1588

Author: Tadas Mazutis

src/Microsoft.AspNetCore.NodeServices/Content/Node/entrypoint-http.js

@@ -121,8 +121,8 @@
 varparsedArgs=ArgsUtil_1.parseArgs(process.argv);
 varrequestedPortOrZero=parsedArgs.port||0;// 0 means 'let the OS decide'
 server.listen(requestedPortOrZero,'localhost',function(){
-// Signal to HttpNodeHost which port it should make its HTTP connections on
-console.log('[Microsoft.AspNetCore.NodeServices.HttpNodeHost:Listening on port '+server.address().port+'\]');
+// Signal to HttpNodeHost which loopback IP address (IPv4 or IPv6) and port it should make its HTTP connections on
+console.log('[Microsoft.AspNetCore.NodeServices.HttpNodeHost:Listening on {'+server.address().address+'} port '+server.address().port+'\]');
 // Signal to the NodeServices base class that we're ready to accept invocations
 console.log('[Microsoft.AspNetCore.NodeServices:Listening]');
 });

src/Microsoft.AspNetCore.NodeServices/HostingModels/HttpNodeInstance.cs

@@ -21,8 +21,8 @@ namespace Microsoft.AspNetCore.NodeServices.HostingModels
 /// <seealso cref="Microsoft.AspNetCore.NodeServices.HostingModels.OutOfProcessNodeInstance" />
 internalclassHttpNodeInstance:OutOfProcessNodeInstance
 {
-privatestaticreadonlyRegexPortMessageRegex=
-newRegex(@"^\[Microsoft.AspNetCore.NodeServices.HttpNodeHost:Listening on port (\d+)\]$");
+privatestaticreadonlyRegexEndpointMessageRegex=
+newRegex(@"^\[Microsoft.AspNetCore.NodeServices.HttpNodeHost:Listening on {(.*?)} port (\d+)\]$");
 
 privatestaticreadonlyJsonSerializerSettingsjsonSerializerSettings=newJsonSerializerSettings
 {
@@ -32,7 +32,7 @@ internal class HttpNodeInstance : OutOfProcessNodeInstance
 
 privatereadonlyHttpClient_client;
 privatebool_disposed;
-privateint_portNumber;
+privatestring_endpoint;
 
 publicHttpNodeInstance(NodeServicesOptionsoptions,intport=0)
 :base(
@@ -63,7 +63,7 @@ protected override async Task<T> InvokeExportAsync<T>(
 {
 varpayloadJson=JsonConvert.SerializeObject(invocationInfo,jsonSerializerSettings);
 varpayload=newStringContent(payloadJson,Encoding.UTF8,"application/json");
-varresponse=await_client.PostAsync("http://localhost:"+_portNumber,payload,cancellationToken);
+varresponse=await_client.PostAsync(_endpoint,payload,cancellationToken);
 
 if(!response.IsSuccessStatusCode)
 {
@@ -111,13 +111,19 @@ protected override async Task<T> InvokeExportAsync<T>(
 
 protectedoverridevoidOnOutputDataReceived(stringoutputData)
 {
-// Watch for "port selected" messages, and when observed, store the port number
+// Watch for "port selected" messages, and when observed, 
+// store the IP (IPv4/IPv6) and port number
 // so we can use it when making HTTP requests. The child process will always send
 // one of these messages before it sends a "ready for connections" message.
-varmatch=_portNumber!=0?null:PortMessageRegex.Match(outputData);
+varmatch=string.IsNullOrEmpty(_endpoint)?EndpointMessageRegex.Match(outputData):null;
 if(match!=null&&match.Success)
 {
-_portNumber=int.Parse(match.Groups[1].Captures[0].Value);
+varport=int.Parse(match.Groups[2].Captures[0].Value);
+varresolvedIpAddress=match.Groups[1].Captures[0].Value;
+
+//IPv6 must be wrapped with [] brackets
+resolvedIpAddress=resolvedIpAddress=="::1"?$"[{resolvedIpAddress}]":resolvedIpAddress;
+_endpoint=$"http://{resolvedIpAddress}:{port}";
 }
 else
 {

src/Microsoft.AspNetCore.NodeServices/TypeScript/HttpNodeInstanceEntryPoint.ts

@@ -70,8 +70,8 @@ const server = http.createServer((req, res) =>{
 constparsedArgs=parseArgs(process.argv);
 constrequestedPortOrZero=parsedArgs.port||0;// 0 means 'let the OS decide'
 server.listen(requestedPortOrZero,'localhost',function(){
-// Signal to HttpNodeHost which port it should make its HTTP connections on
-console.log('[Microsoft.AspNetCore.NodeServices.HttpNodeHost:Listening on port '+server.address().port+'\]');
+// Signal to HttpNodeHost which loopback IP address (IPv4 or IPv6) and port it should make its HTTP connections on
+console.log('[Microsoft.AspNetCore.NodeServices.HttpNodeHost:Listening on {'+server.address().address+'} port '+server.address().port+'\]');
 
 // Signal to the NodeServices base class that we're ready to accept invocations
 console.log('[Microsoft.AspNetCore.NodeServices:Listening]');