feat!: maybeCoerceNumber() now takes into account arrays (#187)

BREAKING CHANGE: unless "parse-numbers" is set to "false", arrays of numeric strings are now parsed as numbers, rather than strings.

Author: juergba

index.js

@@ -470,7 +470,9 @@ function parse (args, opts){
 if(typeofval==='string')val=val==='true'
 }
 
-varvalue=maybeCoerceNumber(key,val)
+varvalue=Array.isArray(val)
+ ? val.map(function(v){returnmaybeCoerceNumber(key,v)})
+ : maybeCoerceNumber(key,val)
 
 // increment a count given as arg (either no value or value parsed as boolean)
 if(checkAllAliases(key,flags.counts)&&(isUndefined(value)||typeofvalue==='boolean')){
@@ -486,7 +488,7 @@ function parse (args, opts){
 }
 
 functionmaybeCoerceNumber(key,value){
-if(!checkAllAliases(key,flags.strings)){
+if(!checkAllAliases(key,flags.strings)&&!checkAllAliases(key,flags.bools)&&!Array.isArray(value)){
 constshouldCoerceNumber=isNumber(value)&&configuration['parse-numbers']&&(
 Number.isSafeInteger(Math.floor(value))
 )

test/yargs-parser.js

@@ -2160,6 +2160,19 @@ describe('yargs-parser', function (){
 expect(parsed['bar']).to.equal(6)
 expect(parsed['baz']).to.equal(7)
 })
+
+it('should coerce elements of number typed arrays to numbers',function(){
+varparsed=parser(['--foo','4','--foo','5','2'],{
+array: ['foo'],
+configObjects: [{foo: ['1','2','3']}],
+configuration: {
+'combine-arrays': true,
+'flatten-duplicate-arrays': false
+}
+})
+
+expect(parsed['foo']).to.deep.equal([[4],[5,2],[1,2,3]])
+})
 })
 
 describe('boolean negation',function(){
@@ -2445,15 +2458,15 @@ describe('yargs-parser', function (){
 })
 describe('duplicate=true, flatten=false,',function(){
 describe('type=array',function(){
-it('[-x 1 -x 2 -x 3] => [1, 2, 3]',function(){
+it('[-x 1 -x 2 -x 3] => [[1], [2], [3]]',function(){
 varparsed=parser('-x 1 -x 2 -x 3',{
 array: ['x'],
 configuration: {
 'duplicate-arguments-array': true,
 'flatten-duplicate-arrays': false
 }
 })
-parsed['x'].should.deep.equal([1,2,3])
+parsed['x'].should.deep.equal([[1],[2],[3]])
 })
 it('[-x 1 2 3 -x 2 3 4] => [[1, 2, 3], [ 2, 3, 4]]',function(){
 varparsed=parser('-x 1 2 3 -x 2 3 4',{