Merge pull request TheAlgorithms#34 from edawine/patch-1

harshildarji · web-flow · commit cebbf567ec17 · 2016-10-08T22:46:37.000+05:30
Add another randomness into the password generator
diff --git a/other/password_generator.py b/other/password_generator.py
@@ -1,13 +1,14 @@
 import string
-from random import *
+import random
 
-letters = string.ascii_letters
-digits = string.digits
-symbols = string.punctuation
+letters = [letter for letter in string.ascii_letters]
+digits = [digit for digit in string.digits]
+symbols = [symbol for symbol in string.punctuation]
 chars = letters + digits + symbols
+random.shuffle(chars)
 
 min_length = 8
 max_length = 16
-password = ''.join(choice(chars) for x in range(randint(min_length, max_length)))
-print('Password: %s' % password)
+password = ''.join(random.choice(chars) for x in range(random.randint(min_length, max_length)))
+print('Password: ' + password)
 print('[ If you are thinking of using this passsword, You better save it. ]')

-Original file line number
+Diff line change
@@ @@ -1,13 +1,14 @@ @@
 importstring
 -fromrandomimport*
 +importrandom
 -letters=string.ascii_letters
 -digits=string.digits
 -symbols=string.punctuation
 +letters=[letterforletterinstring.ascii_letters]
 +digits=[digitfordigitinstring.digits]
 +symbols=[symbolforsymbolinstring.punctuation]
 chars=letters+digits+symbols
 +random.shuffle(chars)
 min_length=8
 max_length=16
 -password=''.join(choice(chars) forxinrange(randint(min_length, max_length)))
 -print('Password: %s'%password)
 +password=''.join(random.choice(chars) forxinrange(random.randint(min_length, max_length)))
 +print('Password: '+password)
 print('[ If you are thinking of using this passsword, You better save it. ]')