- Notifications
You must be signed in to change notification settings - Fork 765
Fix headers for clang 6 build#417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Conversation
aknarts commented May 16, 2018 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Just a note this still fails with: Looking into it, this is not this plugins issue but more of an engine not supporting clang 6 yet officially(Although it builds and compiles ok). |
rdeioris commented May 17, 2018
Hi, the error is present in clang-3.9 too. I am investigating if i can bypass it |
aknarts commented May 18, 2018 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
I found a way to bypass it but it requires modification of the fbxproperty.h which is not really desirable from the plugin standpoint. Just for the posterity this works:(line 1188 in Engine/Source/ThirdParty/FBX/2018.1.1/include/fbxsdk/core/fbxproperty.h) After this the errors move a bit further(working on it). I might just be building it wrong at this point
|
mmmaat commented May 30, 2018
Hello, I experimented the same error with the FBX module when compiling with clang-3.9 on the new Ubuntu-18.04 (clang-3.8 is no more available on that distribution). The fix you propose @aknarts works pretty well. So modifying line 1188 in Engine/Source/ThirdParty/FBX/2018.1.1/include/fbxsdk/core/fbxproperty.h is sufficient: Thank you! |
Fixes these issues during the build: