Skip to content

Conversation

@mdmuhtasimfuadfahim
Copy link

@mdmuhtasimfuadfahimmdmuhtasimfuadfahim commented Apr 27, 2023

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@Ashutosh00710
Copy link
Owner

Ashutosh00710 commented Apr 29, 2023

Hi @mdmuhtasimfuadfahim, thank you for your pull request. I have reviewed your PR and unfortunately, it seems that the vercel.json file you provided is not functioning as expected. The current implementation just redirects the project back to my repository. However, there is another PR (#195) that addresses this issue and provides the correct implementation of the vercel.json file. Therefore, I have to close this PR with this comment. Thank you for your contribution!

@Ashutosh00710Ashutosh00710 added duplicate This issue or pull request already exists enhancement New feature or request dev-ops labels Apr 29, 2023
@mdmuhtasimfuadfahim
Copy link
Author

mdmuhtasimfuadfahim commented Apr 29, 2023 via email

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-opsduplicateThis issue or pull request already existsenhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mdmuhtasimfuadfahim@Ashutosh00710