Temporarily pin NodeTestVersion of v21 to 21.2.0#27951
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jeremymengforce-pushed the identity/mac-nodejs-21.2.0 branch 2 times, most recently from ebd266a to 002821eCompare
Latest 21.3.0 contains changes that breaks `writeFileSync` of temp files on MacOS. This PR unblocks `js - core` release pipeline while we follow up on the NodeJS issue.
jeremymengforce-pushed the identity/mac-nodejs-21.2.0 branch from 002821e to d120796Comparejeremymeng changed the title jeremymeng requested review from benbp, ckairen, mikeharder and weshaggard as code owners
MuriloKakazu commented Dec 1, 2023
This can be reverted when the fix is released: nodejs/node#50990 Alternatively, you can pass |
weshaggard approved these changes Dec 1, 2023
Member
weshaggard left a comment
weshaggard left a comment There was a problem hiding this comment.
Lets be sure to file a follow-up issue.
MemberAuthor
jeremymeng commented Dec 1, 2023
|
jeremymeng added a commit to jeremymeng/azure-sdk-for-js that referenced this pull request Dec 6, 2023
now that a fix to `fs.writeFileSync` has been released. Revert "Temporarily pin NodeTestVersion of v21 to 21.2.0 (Azure#27951)" This reverts commit b1a31b3.
jeremymeng added a commit that referenced this pull request Dec 6, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest 21.3.0 contains changes that breaks
writeFileSyncof temp files onMacOS. This PR unblocks
js - corerelease pipeline while we follow up on theNodeJS issue.