Extend docblock about same and equals regarding their type safety#60
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've stumbled into a mean error in my tests by using
verify()->equals()all the time assuming it would perform a type safe comparison. At a certain point, I found out that I must useverify()->same()for a type safe comparison. Since I wasn't aware ofequalsbeing type-unsafe andsameexisting, I've added a bit about them to their respective documentation blocks in the hope it will help others as well.