Table Views for Evals Pages#162
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
liam-middlebrook requested changes Dec 2, 2017
Member
liam-middlebrook left a comment
liam-middlebrook left a comment There was a problem hiding this comment.
Looks good to me. It feels weird to only leave nitpick-y feedback, but I guess that means that you did a good job on the changes. 👍
| </div> | ||
| {% endfor %} | ||
| </div> |
There was a problem hiding this comment.
I'm not really sure which block this is supposed to align to? (I want to say <div class="row mobile-hide">)
| <divclass="col-sm-10"> | ||
| <h3class="page-title">Intro Evaluations</h3> | ||
| </div> | ||
| <divclass="col-sm-2"> |
There was a problem hiding this comment.
Could you re-align the indentation levels in this block for better readability?
There was a problem hiding this comment.
To clarify I mean the block under line 11, I'm not sure why GitHub's preview is showing the lines above.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a table view that you can toggle into from evaluations pages.
I guess this fixes#128 too.