Skip to content

Conditional 1.6.1#165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbillow merged 2 commits into from
Jan 6, 2018
Merged

Conditional 1.6.1 #165

mbillow merged 2 commits into from
Jan 6, 2018

Conversation

@mbillow
Copy link
Member

@mbillowmbillow commented Dec 21, 2017•
edited
Loading

In the words of Emeril Lagasse, BAM!

(Fixes#164)

@mbillowmbillow self-assigned this Dec 21, 2017
@mbillow
Copy link
MemberAuthor

mbillow commented Dec 21, 2017

It looks like a new version of Pylint is introducing more checks and causing the build to fail. None of the build errors are in files I changed.

liam-middlebrook
liam-middlebrook requested changes Dec 21, 2017
View reviewed changes
Copy link
Member

@liam-middlebrookliam-middlebrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be titled as a version bump? (Did you mean to push this to develop and then have the PR be cutting a release?)

If this is supposed to be a version bump I think you should add an additional commit fixing the pylint errors that were caused by what appears to be new pylint settings. Or just set the version of pylint in requirements.txt to what ran before these issues appeared.

@mbillowmbillow changed the title Semester Based CM Reqs (Fixes #164)Conditional 1.6.1Jan 4, 2018
@mbillow
Copy link
MemberAuthor

mbillow commented Jan 4, 2018

Yes, it should have been, my bad. Upgraded to the latest PyLint version and fixed the problems it found. CI passes now.

liam-middlebrook
liam-middlebrook approved these changes Jan 6, 2018
View reviewed changes
Copy link
Member

@liam-middlebrookliam-middlebrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mbillowmbillow merged commit bdb6d21 into masterJan 6, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liam-middlebrookliam-middlebrookliam-middlebrook approved these changes

Assignees

@mbillowmbillow

Labels

enhancementversion-bump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mbillow@liam-middlebrook