Skip to content

fix: http.url tag to include protocol#603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
duncanista merged 4 commits into from
May 23, 2025
Merged

fix: http.url tag to include protocol #603

duncanista merged 4 commits into from
May 23, 2025

Conversation

@duncanista
Copy link
Contributor

@duncanistaduncanista commented May 23, 2025•
edited
Loading

What does this PR do?

Updates http.url tag to include protocol.

Motivation

Issue where Next Gen Extension was not able to parse it as a URL, this will be fixed there, but this should include the protocol.

Testing Guidelines

Unit test and integration tests.

Additional Notes

n/a

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@duncanistaduncanista changed the title Jordan.gonzalez/inferred spans/fix http urlfix: http.url tag to include protocolMay 23, 2025
@duncanistaduncanista marked this pull request as ready for review May 23, 2025 12:23
@duncanistaduncanista requested review from a team as code ownersMay 23, 2025 12:23
@duncanistaduncanista merged commit 64f81da into mainMay 23, 2025
60 checks passed
@duncanistaduncanista deleted the jordan.gonzalez/inferred-spans/fix-http-url branch May 23, 2025 14:15
purple4reina
purple4reina reviewed May 23, 2025
View reviewed changes
Copy link
Contributor

@purple4reinapurple4reina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@purple4reinapurple4reinapurple4reina left review comments

@lucaspimentellucaspimentellucaspimentel approved these changes

+1 more reviewer

@hghotrahghotrahghotra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@duncanista@purple4reina@lucaspimentel@hghotra