bugfix: error metrics should be sent during exception handling#626
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
datadog_lambda/wrapper.py Outdated
Comment on lines 167 to 171
| exceptException: | ||
| ifnotshould_use_extension: | ||
| ifshould_use_extension: | ||
| fromdatadog_lambda.metricimportsubmit_errors_metric | ||
| submit_errors_metric(context) |
Contributor
There was a problem hiding this comment.
before, it worked like:
exceptException: fromdatadog_lambda.metricimportsubmit_errors_metricsubmit_errors_metric(context)we weren't checking for extension at all
ContributorAuthor
There was a problem hiding this comment.
updated accordingly.
joeyzhao2018force-pushed the joey/fix_error_metrics branch 4 times, most recently from 59e1bc0 to 9413991Compare
Signed-off-by: Joey Zhao <[email protected]>
joeyzhao2018force-pushed the joey/fix_error_metrics branch from 9413991 to bb41689Comparejoeyzhao2018 merged commit 495c770 into main 61 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply