- Notifications
You must be signed in to change notification settings - Fork 323
Enabling optimized map by default#10016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Conversation
dougqh commented Nov 21, 2025 • edited by bric3
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bric3
Uh oh!
There was an error while loading. Please reload this page.
github-actionsbot commented Nov 21, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
pr-commenterbot commented Nov 25, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~757a4c06cb, baseline=1.59.0-SNAPSHOT~6d2b809818 dateFormat X axisFormat %s section tracing Agent [baseline] (1.081 s) : 0, 1081249 Total [baseline] (10.728 s) : 0, 10728365 Agent [candidate] (1.088 s) : 0, 1088284 Total [candidate] (10.761 s) : 0, 10760571 section appsec Agent [baseline] (1.268 s) : 0, 1267773 Total [baseline] (10.896 s) : 0, 10895532 Agent [candidate] (1.271 s) : 0, 1271444 Total [candidate] (11.098 s) : 0, 11097784 section iast Agent [baseline] (1.225 s) : 0, 1225414 Total [baseline] (11.173 s) : 0, 11173445 Agent [candidate] (1.223 s) : 0, 1222777 Total [candidate] (11.196 s) : 0, 11196500 section profiling Agent [baseline] (1.208 s) : 0, 1207840 Total [baseline] (11.005 s) : 0, 11004810 Agent [candidate] (1.204 s) : 0, 1204067 Total [candidate] (10.85 s) : 0, 10849615
gantt title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~757a4c06cb, baseline=1.59.0-SNAPSHOT~6d2b809818 dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.179 ms) : 0, 1179 crashtracking [candidate] (1.201 ms) : 0, 1201 BytebuddyAgent [baseline] (649.249 ms) : 0, 649249 BytebuddyAgent [candidate] (653.476 ms) : 0, 653476 GlobalTracer [baseline] (281.609 ms) : 0, 281609 GlobalTracer [candidate] (283.193 ms) : 0, 283193 AppSec [baseline] (32.425 ms) : 0, 32425 AppSec [candidate] (32.877 ms) : 0, 32877 Debugger [baseline] (68.165 ms) : 0, 68165 Debugger [candidate] (68.644 ms) : 0, 68644 Remote Config [baseline] (603.298 µs) : 0, 603 Remote Config [candidate] (635.772 µs) : 0, 636 Telemetry [baseline] (8.84 ms) : 0, 8840 Telemetry [candidate] (8.979 ms) : 0, 8979 Flare Poller [baseline] (3.696 ms) : 0, 3696 Flare Poller [candidate] (3.751 ms) : 0, 3751 section appsec crashtracking [baseline] (1.197 ms) : 0, 1197 crashtracking [candidate] (1.194 ms) : 0, 1194 BytebuddyAgent [baseline] (692.765 ms) : 0, 692765 BytebuddyAgent [candidate] (694.185 ms) : 0, 694185 GlobalTracer [baseline] (258.858 ms) : 0, 258858 GlobalTracer [candidate] (259.098 ms) : 0, 259098 AppSec [baseline] (173.41 ms) : 0, 173410 AppSec [candidate] (173.556 ms) : 0, 173556 Debugger [baseline] (67.577 ms) : 0, 67577 Debugger [candidate] (69.298 ms) : 0, 69298 Remote Config [baseline] (774.163 µs) : 0, 774 Remote Config [candidate] (751.274 µs) : 0, 751 Telemetry [baseline] (9.293 ms) : 0, 9293 Telemetry [candidate] (9.484 ms) : 0, 9484 Flare Poller [baseline] (3.763 ms) : 0, 3763 Flare Poller [candidate] (3.846 ms) : 0, 3846 IAST [baseline] (24.673 ms) : 0, 24673 IAST [candidate] (24.575 ms) : 0, 24575 section iast crashtracking [baseline] (1.179 ms) : 0, 1179 crashtracking [candidate] (1.169 ms) : 0, 1169 BytebuddyAgent [baseline] (792.377 ms) : 0, 792377 BytebuddyAgent [candidate] (790.897 ms) : 0, 790897 GlobalTracer [baseline] (256.222 ms) : 0, 256222 GlobalTracer [candidate] (255.816 ms) : 0, 255816 AppSec [baseline] (34.38 ms) : 0, 34380 AppSec [candidate] (35.043 ms) : 0, 35043 Debugger [baseline] (66.078 ms) : 0, 66078 Debugger [candidate] (64.843 ms) : 0, 64843 Remote Config [baseline] (590.965 µs) : 0, 591 Remote Config [candidate] (571.954 µs) : 0, 572 Telemetry [baseline] (8.476 ms) : 0, 8476 Telemetry [candidate] (8.479 ms) : 0, 8479 Flare Poller [baseline] (3.489 ms) : 0, 3489 Flare Poller [candidate] (3.509 ms) : 0, 3509 IAST [baseline] (27.262 ms) : 0, 27262 IAST [candidate] (27.079 ms) : 0, 27079 section profiling crashtracking [baseline] (1.214 ms) : 0, 1214 crashtracking [candidate] (1.223 ms) : 0, 1223 BytebuddyAgent [baseline] (704.125 ms) : 0, 704125 BytebuddyAgent [candidate] (701.854 ms) : 0, 701854 GlobalTracer [baseline] (221.174 ms) : 0, 221174 GlobalTracer [candidate] (220.975 ms) : 0, 220975 AppSec [baseline] (32.568 ms) : 0, 32568 AppSec [candidate] (32.24 ms) : 0, 32240 Debugger [baseline] (68.297 ms) : 0, 68297 Debugger [candidate] (67.737 ms) : 0, 67737 Remote Config [baseline] (659.569 µs) : 0, 660 Remote Config [candidate] (654.599 µs) : 0, 655 Telemetry [baseline] (8.851 ms) : 0, 8851 Telemetry [candidate] (8.814 ms) : 0, 8814 Flare Poller [baseline] (3.687 ms) : 0, 3687 Flare Poller [candidate] (4.306 ms) : 0, 4306 ProfilingAgent [baseline] (97.362 ms) : 0, 97362 ProfilingAgent [candidate] (96.463 ms) : 0, 96463 Profiling [baseline] (97.953 ms) : 0, 97953 Profiling [candidate] (97.052 ms) : 0, 97052 Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~757a4c06cb, baseline=1.59.0-SNAPSHOT~6d2b809818 dateFormat X axisFormat %s section tracing Agent [baseline] (1.09 s) : 0, 1089736 Total [baseline] (8.739 s) : 0, 8738654 Agent [candidate] (1.082 s) : 0, 1081957 Total [candidate] (8.752 s) : 0, 8751650 section iast Agent [baseline] (1.224 s) : 0, 1224009 Total [baseline] (9.266 s) : 0, 9265528 Agent [candidate] (1.222 s) : 0, 1221745 Total [candidate] (9.298 s) : 0, 9297592
gantt title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~757a4c06cb, baseline=1.59.0-SNAPSHOT~6d2b809818 dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.194 ms) : 0, 1194 crashtracking [candidate] (1.176 ms) : 0, 1176 BytebuddyAgent [baseline] (655.787 ms) : 0, 655787 BytebuddyAgent [candidate] (650.171 ms) : 0, 650171 GlobalTracer [baseline] (283.554 ms) : 0, 283554 GlobalTracer [candidate] (281.917 ms) : 0, 281917 AppSec [baseline] (32.792 ms) : 0, 32792 AppSec [candidate] (32.534 ms) : 0, 32534 Debugger [baseline] (67.374 ms) : 0, 67374 Debugger [candidate] (67.352 ms) : 0, 67352 Remote Config [baseline] (609.473 µs) : 0, 609 Remote Config [candidate] (630.458 µs) : 0, 630 Telemetry [baseline] (8.966 ms) : 0, 8966 Telemetry [candidate] (8.96 ms) : 0, 8960 Flare Poller [baseline] (3.754 ms) : 0, 3754 Flare Poller [candidate] (3.793 ms) : 0, 3793 section iast crashtracking [baseline] (1.182 ms) : 0, 1182 crashtracking [candidate] (1.172 ms) : 0, 1172 BytebuddyAgent [baseline] (792.155 ms) : 0, 792155 BytebuddyAgent [candidate] (790.792 ms) : 0, 790792 GlobalTracer [baseline] (256.008 ms) : 0, 256008 GlobalTracer [candidate] (256.073 ms) : 0, 256073 AppSec [baseline] (35.099 ms) : 0, 35099 AppSec [candidate] (34.282 ms) : 0, 34282 Debugger [baseline] (64.109 ms) : 0, 64109 Debugger [candidate] (64.588 ms) : 0, 64588 Remote Config [baseline] (608.255 µs) : 0, 608 Remote Config [candidate] (566.339 µs) : 0, 566 Telemetry [baseline] (8.547 ms) : 0, 8547 Telemetry [candidate] (8.434 ms) : 0, 8434 Flare Poller [baseline] (3.662 ms) : 0, 3662 Flare Poller [candidate] (3.517 ms) : 0, 3517 IAST [baseline] (27.144 ms) : 0, 27144 IAST [candidate] (27.03 ms) : 0, 27030 LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~757a4c06cb, baseline=1.59.0-SNAPSHOT~6d2b809818 dateFormat X axisFormat %s section baseline no_agent (17.181 ms) : 17012, 17351 . : milestone, 17181, appsec (18.593 ms) : 18405, 18781 . : milestone, 18593, code_origins (17.608 ms) : 17434, 17781 . : milestone, 17608, iast (17.501 ms) : 17328, 17673 . : milestone, 17501, profiling (18.781 ms) : 18589, 18973 . : milestone, 18781, tracing (17.699 ms) : 17525, 17872 . : milestone, 17699, section candidate no_agent (18.977 ms) : 18783, 19170 . : milestone, 18977, appsec (18.985 ms) : 18795, 19175 . : milestone, 18985, code_origins (17.801 ms) : 17623, 17979 . : milestone, 17801, iast (17.656 ms) : 17482, 17831 . : milestone, 17656, profiling (18.729 ms) : 18541, 18916 . : milestone, 18729, tracing (17.449 ms) : 17276, 17623 . : milestone, 17449,
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~757a4c06cb, baseline=1.59.0-SNAPSHOT~6d2b809818 dateFormat X axisFormat %s section baseline no_agent (1.187 ms) : 1175, 1199 . : milestone, 1187, iast (3.267 ms) : 3224, 3309 . : milestone, 3267, iast_FULL (5.783 ms) : 5725, 5840 . : milestone, 5783, iast_GLOBAL (3.796 ms) : 3739, 3854 . : milestone, 3796, profiling (2.063 ms) : 2045, 2082 . : milestone, 2063, tracing (1.795 ms) : 1779, 1810 . : milestone, 1795, section candidate no_agent (1.201 ms) : 1189, 1213 . : milestone, 1201, iast (3.198 ms) : 3150, 3246 . : milestone, 3198, iast_FULL (5.63 ms) : 5574, 5686 . : milestone, 5630, iast_GLOBAL (3.596 ms) : 3541, 3651 . : milestone, 3596, profiling (1.975 ms) : 1957, 1993 . : milestone, 1975, tracing (1.757 ms) : 1743, 1770 . : milestone, 1757,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~757a4c06cb, baseline=1.59.0-SNAPSHOT~6d2b809818 dateFormat X axisFormat %s section baseline no_agent (15.542 s) : 15542000, 15542000 . : milestone, 15542000, appsec (14.682 s) : 14682000, 14682000 . : milestone, 14682000, iast (18.21 s) : 18210000, 18210000 . : milestone, 18210000, iast_GLOBAL (17.827 s) : 17827000, 17827000 . : milestone, 17827000, profiling (14.851 s) : 14851000, 14851000 . : milestone, 14851000, tracing (14.962 s) : 14962000, 14962000 . : milestone, 14962000, section candidate no_agent (15.432 s) : 15432000, 15432000 . : milestone, 15432000, appsec (14.684 s) : 14684000, 14684000 . : milestone, 14684000, iast (17.99 s) : 17990000, 17990000 . : milestone, 17990000, iast_GLOBAL (17.881 s) : 17881000, 17881000 . : milestone, 17881000, profiling (15.248 s) : 15248000, 15248000 . : milestone, 15248000, tracing (14.718 s) : 14718000, 14718000 . : milestone, 14718000,
Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~757a4c06cb, baseline=1.59.0-SNAPSHOT~6d2b809818 dateFormat X axisFormat %s section baseline no_agent (1.474 ms) : 1463, 1486 . : milestone, 1474, appsec (3.739 ms) : 3519, 3960 . : milestone, 3739, iast (2.215 ms) : 2151, 2280 . : milestone, 2215, iast_GLOBAL (2.257 ms) : 2192, 2323 . : milestone, 2257, profiling (2.087 ms) : 2032, 2142 . : milestone, 2087, tracing (2.06 ms) : 2008, 2111 . : milestone, 2060, section candidate no_agent (1.475 ms) : 1464, 1487 . : milestone, 1475, appsec (3.709 ms) : 3492, 3927 . : milestone, 3709, iast (2.207 ms) : 2142, 2272 . : milestone, 2207, iast_GLOBAL (2.254 ms) : 2188, 2320 . : milestone, 2254, profiling (2.07 ms) : 2017, 2123 . : milestone, 2070, tracing (2.048 ms) : 1997, 2100 . : milestone, 2048,
|
| this.optimizedMapEnabled = | ||
| configProvider.getBoolean(GeneralConfig.OPTIMIZED_MAP_ENABLED, false); | ||
| this.optimizedMapEnabled = configProvider.getBoolean(GeneralConfig.OPTIMIZED_MAP_ENABLED, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, if it is a config change, do we need to update some other place too?
@mhlidd Could you check this PR too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that only applies if we introduce a config variable. This config has been in place for some time now.
What Does This Do
Enables the "optimized" TagMap by default
Motivation
OptimizedTagMap is special HashMap that is designed to be good at common tracer usage patterns.
OptimizedTagMap uses immutable TagMap.Entry-s
By using immutable TagMap.Entry-s...
TagMap.Entry-s are also capable of storing primitives without boxing
All of these capabilities are intended to minimize the allocation done by the tracer when constructing Span-s
Additional Notes
Follow-up to
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]