Skip to content

Conversation

@joeshannon
Copy link
Contributor

Yield tests were removed in pytest 4. Convert to parameterized.

Yield tests were removed in pytest 4. Convert to parameterized.
@joeshannon
Copy link
ContributorAuthor

The final test file to be migrated is test/diffcalc/hkl/you/test_calc.py but this is significantly more complex.

@joeshannonjoeshannon marked this pull request as ready for review April 6, 2022 16:22
@joeshannon
Copy link
ContributorAuthor

To prevent blocking other work (and given that there is currently no CI running for the project) it is probably reasonable to merge this now then create another ticket/issue to fix the remaining test file.

@peterholloway would you mind reviewing the migration in these two PR tests?

@joeshannonjoeshannon changed the title Migrate to pytest 4Draft: Migrate to pytest 4Jun 16, 2022
@joeshannonjoeshannon changed the title Draft: Migrate to pytest 4WIP: Migrate to pytest 4Jun 16, 2022
@joeshannonjoeshannon changed the title WIP: Migrate to pytest 4Migrate to pytest 4Jun 16, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@joeshannon